diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-01-27 00:38:35 +0800 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2018-02-27 15:52:13 +0200 |
| commit | 8100091d02487ff267af0d410ceb9eefebc8ea03 (patch) | |
| tree | da22bf476d964aaa59c6ac7a293046f79a1947a7 | |
| parent | 3142467fc15ba19a327dcedafcf913bc7832f6d1 (diff) | |
| download | lwn-8100091d02487ff267af0d410ceb9eefebc8ea03.tar.gz lwn-8100091d02487ff267af0d410ceb9eefebc8ea03.zip | |
bcma: Replace mdelay with usleep_range in bcma_pmu_resources_init
After checking all possible call chains to bcma_pmu_resources_init() here,
my tool finds that this function is never called in atomic context,
namely never in an interrupt handler or holding a spinlock.
Thus mdelay can be replaced with usleep_range to avoid busy wait.
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
| -rw-r--r-- | drivers/bcma/driver_chipcommon_pmu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/bcma/driver_chipcommon_pmu.c b/drivers/bcma/driver_chipcommon_pmu.c index f1eb4d3e1d57..f4161064365c 100644 --- a/drivers/bcma/driver_chipcommon_pmu.c +++ b/drivers/bcma/driver_chipcommon_pmu.c @@ -203,7 +203,7 @@ static void bcma_pmu_resources_init(struct bcma_drv_cc *cc) * Add some delay; allow resources to come up and settle. * Delay is required for SoC (early init). */ - mdelay(2); + usleep_range(2000, 2500); } /* Disable to allow reading SPROM. Don't know the adventages of enabling it. */ |