diff options
| author | Dan Williams <dan.j.williams@intel.com> | 2019-08-07 14:31:11 -0700 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2019-08-14 18:04:39 -0700 |
| commit | 5518ba4ebd7d1e15fc558af05fa600198535f074 (patch) | |
| tree | cc2d93fcdfc86334bf1be863a48066818b82b976 | |
| parent | 49bddc73d15c25a68e4294d76fc74519fda984cd (diff) | |
| download | lwn-5518ba4ebd7d1e15fc558af05fa600198535f074.tar.gz lwn-5518ba4ebd7d1e15fc558af05fa600198535f074.zip | |
tools/testing/nvdimm: Fix fallthrough warning
Use the expected 'fall through' designation to fix:
tools/testing/nvdimm/test/nfit.c: In function ‘nd_intel_test_finish_query’:
tools/testing/nvdimm/test/nfit.c:433:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
fw->state = FW_STATE_UPDATED;
~~~~~~~~~~^~~~~~~~~~~~~~~~~~
tools/testing/nvdimm/test/nfit.c:435:2: note: here
case FW_STATE_UPDATED:
^~~~
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Link: https://lore.kernel.org/r/156521347159.1442374.1381360879102718899.stgit@dwillia2-desk3.amr.corp.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
| -rw-r--r-- | tools/testing/nvdimm/test/nfit.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c index 507e6f4cbb53..bf6422a6af7f 100644 --- a/tools/testing/nvdimm/test/nfit.c +++ b/tools/testing/nvdimm/test/nfit.c @@ -428,10 +428,9 @@ static int nd_intel_test_finish_query(struct nfit_test *t, dev_dbg(dev, "%s: still verifying\n", __func__); break; } - dev_dbg(dev, "%s: transition out verify\n", __func__); fw->state = FW_STATE_UPDATED; - /* we are going to fall through if it's "done" */ + /* fall through */ case FW_STATE_UPDATED: nd_cmd->status = 0; /* bogus test version */ |