diff options
| author | Steve French <sfrench@us.ibm.com> | 2007-09-28 06:53:39 +0000 |
|---|---|---|
| committer | Steve French <sfrench@us.ibm.com> | 2007-09-28 06:53:39 +0000 |
| commit | 407f61a2b482ab9a6d03549ab9513e4a823ae4a2 (patch) | |
| tree | d118f0ed7aea5a0002cbd58ff69fd0fa36b5be1b | |
| parent | 65874007c36930317c7a56d814a6a3e2966daaa8 (diff) | |
| download | lwn-407f61a2b482ab9a6d03549ab9513e4a823ae4a2.tar.gz lwn-407f61a2b482ab9a6d03549ab9513e4a823ae4a2.zip | |
[CIFS] Fix memory leak in statfs to very old servers
We were allocating request buffers twice in the statfs
path when mounted to very old (Windows 9x) servers.
Signed-off-by: Steve French <sfrench@us.ibm.com>
| -rw-r--r-- | fs/cifs/CHANGES | 5 | ||||
| -rw-r--r-- | fs/cifs/cifssmb.c | 4 |
2 files changed, 5 insertions, 4 deletions
diff --git a/fs/cifs/CHANGES b/fs/cifs/CHANGES index 41e3b6a9397c..ea359a0038d9 100644 --- a/fs/cifs/CHANGES +++ b/fs/cifs/CHANGES @@ -1,3 +1,8 @@ +Version 1.51 +------------ +Fix memory leak in statfs when mounted to very old servers (e.g. +Windows 9x) + Version 1.50 ------------ Fix NTLMv2 signing. NFS server mounted over cifs works (if cifs mount is diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index cc05a26ab07a..a6ff324bc135 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c @@ -4045,10 +4045,6 @@ oldQFSInfoRetry: (void **) &pSMBr); if (rc) return rc; - rc = smb_init(SMB_COM_TRANSACTION2, 15, tcon, (void **) &pSMB, - (void **) &pSMBr); - if (rc) - return rc; params = 2; /* level */ pSMB->TotalDataCount = 0; |