diff options
| author | Yang Li <yang.lee@linux.alibaba.com> | 2022-06-13 09:43:21 +0800 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2022-06-16 21:23:18 -0400 |
| commit | 35bf020bd8ab41849871645d8fa83c86cddfe7eb (patch) | |
| tree | a27973460088307e3ce7ffa7750eb8ca0e58f4e0 | |
| parent | 09c962fd4816f31ad428948c1dea3aea33f471e3 (diff) | |
| download | lwn-35bf020bd8ab41849871645d8fa83c86cddfe7eb.tar.gz lwn-35bf020bd8ab41849871645d8fa83c86cddfe7eb.zip | |
scsi: target: iscsi: Fix NULL pointer dereference in iscsi_conn_auth_required()
Fix following coccicheck error:
./drivers/target/iscsi/iscsi_target_nego.c:831:13-26: ERROR: se_nacl is NULL but dereferenced.
Link: https://lore.kernel.org/r/20220613014321.107045-1-yang.lee@linux.alibaba.com
Fixes: a75fcb0912a5 ("scsi: target: iscsi: Extract auth functions")
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
| -rw-r--r-- | drivers/target/iscsi/iscsi_target_nego.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c index 9ce35a59962b..fb93a1173954 100644 --- a/drivers/target/iscsi/iscsi_target_nego.c +++ b/drivers/target/iscsi/iscsi_target_nego.c @@ -827,8 +827,7 @@ static bool iscsi_conn_auth_required(struct iscsit_conn *conn) */ se_nacl = conn->sess->se_sess->se_node_acl; if (!se_nacl) { - pr_debug("Unknown ACL %s is trying to connect\n", - se_nacl->initiatorname); + pr_debug("Unknown ACL is trying to connect\n"); return true; } |