diff options
| author | Andrii Nakryiko <andriin@fb.com> | 2020-06-12 13:16:03 -0700 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2020-06-12 15:25:04 -0700 |
| commit | 22eb78792e07a4dfb63c85f34950d4e58eb90326 (patch) | |
| tree | 07d8d66b127127df8ced2287e57b05bb2d6b8f93 | |
| parent | 60e5ca8a64bad8f3e2e20a1e57846e497361c700 (diff) | |
| download | lwn-22eb78792e07a4dfb63c85f34950d4e58eb90326.tar.gz lwn-22eb78792e07a4dfb63c85f34950d4e58eb90326.zip | |
tools/bpftool: Fix skeleton codegen
Remove unnecessary check at the end of codegen() routine which makes codegen()
to always fail and exit bpftool with error code. Positive value of variable
n is not an indicator of a failure.
Fixes: 2c4779eff837 ("tools, bpftool: Exit on error in function codegen")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Reviewed-by: Tobias Klauser <tklauser@distanz.ch>
Link: https://lore.kernel.org/bpf/20200612201603.680852-1-andriin@fb.com
| -rw-r--r-- | tools/bpf/bpftool/gen.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/tools/bpf/bpftool/gen.c b/tools/bpf/bpftool/gen.c index 7443879e87af..10de76b296ba 100644 --- a/tools/bpf/bpftool/gen.c +++ b/tools/bpf/bpftool/gen.c @@ -257,8 +257,6 @@ static void codegen(const char *template, ...) va_end(args); free(s); - if (n) - exit(-1); } static int do_skeleton(int argc, char **argv) |