summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBastien Curutchet <bastien.curutchet@bootlin.com>2026-05-26 09:10:00 +0200
committerMiquel Raynal <miquel.raynal@bootlin.com>2026-05-27 11:10:25 +0200
commit19ed11aee966d91beebdef9d32ce926474872f79 (patch)
tree1eebb33c58a1f5cabf00355ba6d3beed10aee8a6
parent7fbdbc7d028a20a78b7d28a9510a216c76b5fbfd (diff)
downloadlwn-19ed11aee966d91beebdef9d32ce926474872f79.tar.gz
lwn-19ed11aee966d91beebdef9d32ce926474872f79.zip
mtd: rawnand: pl353: fix probe resource allocation
During probe(), the devm_ioremap() is called with the parent device instead of the current one. So when the module is unloaded, the register area isn't released. Target the pl35x device in the devm_ioremap() instead of its parent. Cc: stable@vger.kernel.org Fixes: 08d8c62164a3 ("mtd: rawnand: pl353: Add support for the ARM PL353 SMC NAND controller") Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
-rw-r--r--drivers/mtd/nand/raw/pl35x-nand-controller.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nand/raw/pl35x-nand-controller.c
index f2c65eb7a8d9..06f8f1e14b9c 100644
--- a/drivers/mtd/nand/raw/pl35x-nand-controller.c
+++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c
@@ -1155,7 +1155,7 @@ static int pl35x_nand_probe(struct platform_device *pdev)
nfc->controller.ops = &pl35x_nandc_ops;
INIT_LIST_HEAD(&nfc->chips);
- nfc->conf_regs = devm_ioremap_resource(&smc_amba->dev, &smc_amba->res);
+ nfc->conf_regs = devm_ioremap_resource(nfc->dev, &smc_amba->res);
if (IS_ERR(nfc->conf_regs))
return PTR_ERR(nfc->conf_regs);