diff options
| author | Josh Poimboeuf <jpoimboe@kernel.org> | 2023-02-13 23:05:41 -0800 |
|---|---|---|
| committer | Josh Poimboeuf <jpoimboe@kernel.org> | 2023-03-06 15:34:06 -0800 |
| commit | 13bf7923a4dd34f3d2681768a148b10ddbdb95ed (patch) | |
| tree | 7c41104d0fe4a93b62be6c67d05f3a823cb96201 | |
| parent | 93c0edffbc92abe1efb8c7081df0cc1577a79ace (diff) | |
| download | lwn-13bf7923a4dd34f3d2681768a148b10ddbdb95ed.tar.gz lwn-13bf7923a4dd34f3d2681768a148b10ddbdb95ed.zip | |
loongarch/cpu: Make sure play_dead() doesn't return
play_dead() doesn't return. Make that more explicit with a BUG().
BUG() is preferable to unreachable() because BUG() is a more explicit
failure mode and avoids undefined behavior like falling off the edge of
the function into whatever code happens to be next.
Link: https://lore.kernel.org/r/21245d687ffeda34dbcf04961a2df3724f04f7c8.1676358308.git.jpoimboe@kernel.org
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
| -rw-r--r-- | arch/loongarch/kernel/smp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/loongarch/kernel/smp.c b/arch/loongarch/kernel/smp.c index 8c6e227cb29d..51f328169a7b 100644 --- a/arch/loongarch/kernel/smp.c +++ b/arch/loongarch/kernel/smp.c @@ -336,7 +336,7 @@ void play_dead(void) iocsr_write32(0xffffffff, LOONGARCH_IOCSR_IPI_CLEAR); init_fn(); - unreachable(); + BUG(); } #endif |