diff options
| author | Richard Lyu <richard.lyu@suse.com> | 2026-09-10 10:44:31 +0800 |
|---|---|---|
| committer | Jarkko Sakkinen <jarkko@kernel.org> | 2026-10-23 00:59:20 +0300 |
| commit | a32b7973d65021486a6ae63d06a575d700eb1f91 (patch) | |
| tree | d29e949ece6ced83d87d480eb6961b18b4c32805 /scripts/basic | |
| parent | 313acd594a799d6b4b3af937eaca7bf4a1803c4a (diff) | |
| download | linux-a32b7973d65021486a6ae63d06a575d700eb1f91.tar.gz linux-a32b7973d65021486a6ae63d06a575d700eb1f91.zip | |
tpm: Remove ineffective wmb() from tpm_pm_resume()
The comment above the wmb() in tpm_pm_resume() states that the barrier
guarantees TPM_CHIP_FLAG_SUSPENDED is written last, so that hwrng does
not activate before the chip has been fully resumed. It cannot do so:
it is placed after the store that clears the flag, and therefore does
not order the preceding resume work before that store. It also has
nothing to pair with, as tpm_try_get_ops() contains no matching read
barrier.
Drop the barrier along with the comment rather than leave a no-op
behind. Should such ordering turn out to be needed, it would require
paired barriers or locking.
Link: https://lore.kernel.org/all/a62fc816-259a-4d28-a265-e425bc17ed50@gmail.com/
Signed-off-by: Richard Lyu <richard.lyu@suse.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Link: https://lore.kernel.org/r/20260910024430.40418-1-richard.lyu@suse.com
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Diffstat (limited to 'scripts/basic')
0 files changed, 0 insertions, 0 deletions
