diff options
| author | Cosmin Ratiu <cratiu@nvidia.com> | 2026-10-20 18:36:59 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-10-21 17:48:38 -0700 |
| commit | e0a958ddfc89f2e1c43448cdaeb5b30e54e19448 (patch) | |
| tree | e56e211e9c23b3fad7e6630a1bfcd5a30a6c3112 /scripts/Makefile.thinlto | |
| parent | 4957ea03bf2696f5da12c09144f48d040696ecc2 (diff) | |
| download | linux-e0a958ddfc89f2e1c43448cdaeb5b30e54e19448.tar.gz linux-e0a958ddfc89f2e1c43448cdaeb5b30e54e19448.zip | |
net/mlx5e: Stop asserting for RTNL when closing channels
mlx5e_close_channels() has an ASSERT_RTNL() from the time when RTNL was
required for closing channels.
But the driver has been switched to using the netdev lock a while back,
and this fired from a flow which was forgotten during the conversion:
mlx5e_tx_timeout_work()
-> mlx5e_reporter_tx_timeout()
-> mlx5e_health_report()
-> mlx5e_tx_reporter_timeout_recover()
-> mlx5e_safe_reopen_channels()
-> mlx5e_safe_switch_params()
-> mlx5e_close_channels()
The RTNL is not acquired here, but the netdev lock is, and it is enough.
Rather than switching to netdev_assert_locked(), simply drop the assert.
Upper layers (networking core, ethtool core) provide locking and lower
layers (NAPI helpers) assert that the netdev lock is held.
Fixes: 8f7b00307bf1 ("net/mlx5e: Convert mlx5 netdevs to instance locking")
Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20261020153659.3440902-1-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'scripts/Makefile.thinlto')
0 files changed, 0 insertions, 0 deletions
