diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2026-10-12 23:10:40 -0700 |
|---|---|---|
| committer | Carlos Maiolino <cem@kernel.org> | 2026-10-14 10:13:51 +0200 |
| commit | ec72fccbc852fdc30bebb31146374fc99ae0b87d (patch) | |
| tree | 13551cbb888bce10ee91e6a8cf8b7d4af841a57e | |
| parent | a55686b2f50500d0a453b43d45677c9824fb4437 (diff) | |
| download | linux-ec72fccbc852fdc30bebb31146374fc99ae0b87d.tar.gz linux-ec72fccbc852fdc30bebb31146374fc99ae0b87d.zip | |
xfs: drop unnecessary sr parameter from xrep_rtgroup init functions
Similar to the last patch, drop this unnecessary sr parameter instead of
dealing with pointer aliasing.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
| -rw-r--r-- | fs/xfs/scrub/bmap_repair.c | 7 | ||||
| -rw-r--r-- | fs/xfs/scrub/cow_repair.c | 4 | ||||
| -rw-r--r-- | fs/xfs/scrub/inode_repair.c | 2 | ||||
| -rw-r--r-- | fs/xfs/scrub/repair.c | 9 | ||||
| -rw-r--r-- | fs/xfs/scrub/repair.h | 6 | ||||
| -rw-r--r-- | fs/xfs/scrub/rtbitmap_repair.c | 2 | ||||
| -rw-r--r-- | fs/xfs/scrub/rtrefcount_repair.c | 2 | ||||
| -rw-r--r-- | fs/xfs/scrub/rtrmap_repair.c | 2 |
8 files changed, 17 insertions, 17 deletions
diff --git a/fs/xfs/scrub/bmap_repair.c b/fs/xfs/scrub/bmap_repair.c index 2fcaf9c5aed9..a4130b03814b 100644 --- a/fs/xfs/scrub/bmap_repair.c +++ b/fs/xfs/scrub/bmap_repair.c @@ -456,10 +456,9 @@ xrep_bmap_scan_rtgroup( if (!xfs_has_rtrmapbt(sc->mp)) return 0; - error = xrep_rtgroup_init(sc, rtg, &sc->sr, - XFS_RTGLOCK_RMAP | - XFS_RTGLOCK_REFCOUNT | - XFS_RTGLOCK_BITMAP_SHARED); + error = xrep_rtgroup_init(sc, rtg, XFS_RTGLOCK_RMAP | + XFS_RTGLOCK_REFCOUNT | + XFS_RTGLOCK_BITMAP_SHARED); if (error) return error; diff --git a/fs/xfs/scrub/cow_repair.c b/fs/xfs/scrub/cow_repair.c index 3d4e94757de0..f2e650c6f7af 100644 --- a/fs/xfs/scrub/cow_repair.c +++ b/fs/xfs/scrub/cow_repair.c @@ -371,8 +371,8 @@ xrep_cow_find_bad_rt( if (!rtg) return -EFSCORRUPTED; - error = xrep_rtgroup_init(sc, rtg, &sc->sr, - XFS_RTGLOCK_RMAP | XFS_RTGLOCK_REFCOUNT); + error = xrep_rtgroup_init(sc, rtg, XFS_RTGLOCK_RMAP | + XFS_RTGLOCK_REFCOUNT); if (error) goto out_rtg; diff --git a/fs/xfs/scrub/inode_repair.c b/fs/xfs/scrub/inode_repair.c index c3842145082f..32aeacfd8da9 100644 --- a/fs/xfs/scrub/inode_repair.c +++ b/fs/xfs/scrub/inode_repair.c @@ -816,7 +816,7 @@ xrep_dinode_count_rtgroup_rmaps( struct xfs_scrub *sc = ri->sc; int error; - error = xrep_rtgroup_init(sc, rtg, &sc->sr, XFS_RTGLOCK_RMAP); + error = xrep_rtgroup_init(sc, rtg, XFS_RTGLOCK_RMAP); if (error) return error; diff --git a/fs/xfs/scrub/repair.c b/fs/xfs/scrub/repair.c index f721e0dad194..3c3820315400 100644 --- a/fs/xfs/scrub/repair.c +++ b/fs/xfs/scrub/repair.c @@ -1046,10 +1046,10 @@ xrep_ag_init( /* Initialize all the btree cursors for a RT repair. */ void xrep_rtgroup_btcur_init( - struct xfs_scrub *sc, - struct xchk_rt *sr) + struct xfs_scrub *sc) { struct xfs_mount *mp = sc->mp; + struct xchk_rt *sr = &sc->sr; ASSERT(sr->rtg != NULL); @@ -1072,9 +1072,10 @@ int xrep_rtgroup_init( struct xfs_scrub *sc, struct xfs_rtgroup *rtg, - struct xchk_rt *sr, unsigned int rtglock_flags) { + struct xchk_rt *sr = &sc->sr; + ASSERT(sr->rtg == NULL); xfs_rtgroup_lock(rtg, rtglock_flags); @@ -1082,7 +1083,7 @@ xrep_rtgroup_init( /* Grab our own passive reference from the caller's ref. */ sr->rtg = xfs_rtgroup_hold(rtg); - xrep_rtgroup_btcur_init(sc, sr); + xrep_rtgroup_btcur_init(sc); return 0; } diff --git a/fs/xfs/scrub/repair.h b/fs/xfs/scrub/repair.h index 6d9be1e8b2a0..842f811491be 100644 --- a/fs/xfs/scrub/repair.h +++ b/fs/xfs/scrub/repair.h @@ -105,13 +105,13 @@ void xrep_ag_btcur_init(struct xfs_scrub *sc); int xrep_ag_init(struct xfs_scrub *sc, struct xfs_perag *pag); #ifdef CONFIG_XFS_RT int xrep_rtgroup_init(struct xfs_scrub *sc, struct xfs_rtgroup *rtg, - struct xchk_rt *sr, unsigned int rtglock_flags); -void xrep_rtgroup_btcur_init(struct xfs_scrub *sc, struct xchk_rt *sr); + unsigned int rtglock_flags); +void xrep_rtgroup_btcur_init(struct xfs_scrub *sc); int xrep_require_rtext_inuse(struct xfs_scrub *sc, xfs_rgblock_t rgbno, xfs_filblks_t len); xfs_extlen_t xrep_calc_rtgroup_resblks(struct xfs_scrub *sc); #else -# define xrep_rtgroup_init(sc, rtg, sr, lockflags) (-ENOSYS) +# define xrep_rtgroup_init(sc, rtg, lockflags) (-ENOSYS) # define xrep_calc_rtgroup_resblks(sc) (0) #endif /* CONFIG_XFS_RT */ diff --git a/fs/xfs/scrub/rtbitmap_repair.c b/fs/xfs/scrub/rtbitmap_repair.c index 34f5017b4ecb..054acbf025f5 100644 --- a/fs/xfs/scrub/rtbitmap_repair.c +++ b/fs/xfs/scrub/rtbitmap_repair.c @@ -339,7 +339,7 @@ xrep_rtbitmap_find_freespace( /* Prepare a buffer of ones so that we can accelerate bulk setting. */ memset(rtb->words, 0xFF, mp->m_sb.sb_blocksize); - xrep_rtgroup_btcur_init(sc, &sc->sr); + xrep_rtgroup_btcur_init(sc); error = xfs_rmap_query_all(sc->sr.rmap_cur, xrep_rtbitmap_walk_rtrmap, rtb); if (error) diff --git a/fs/xfs/scrub/rtrefcount_repair.c b/fs/xfs/scrub/rtrefcount_repair.c index 13b559e506f2..8c384e2df376 100644 --- a/fs/xfs/scrub/rtrefcount_repair.c +++ b/fs/xfs/scrub/rtrefcount_repair.c @@ -418,7 +418,7 @@ xrep_rtrefc_find_refcounts( } } - xrep_rtgroup_btcur_init(sc, &sc->sr); + xrep_rtgroup_btcur_init(sc); /* * Set up a bag to store all the rmap records that we're tracking to diff --git a/fs/xfs/scrub/rtrmap_repair.c b/fs/xfs/scrub/rtrmap_repair.c index 83b5bb7db635..503d29c44bd5 100644 --- a/fs/xfs/scrub/rtrmap_repair.c +++ b/fs/xfs/scrub/rtrmap_repair.c @@ -554,7 +554,7 @@ xrep_rtrmap_find_rmaps( } /* Find CoW staging extents. */ - xrep_rtgroup_btcur_init(sc, &sc->sr); + xrep_rtgroup_btcur_init(sc); error = xrep_rtrmap_find_refcount_rmaps(rr); xchk_rtgroup_btcur_free(&sc->sr); if (error) |
