diff options
| author | Anvik Loitongbam <permissiontogallop@gmail.com> | 2026-10-29 20:17:45 +0530 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2026-10-29 09:29:50 -0600 |
| commit | e18504a4d378b4c9e1ee522ae7fc18cac8b1fc82 (patch) | |
| tree | 1841b24da4cab3adc32a3b027034ece4c9280cd3 | |
| parent | 3de16279b43dc285ed2222aba06cebdc82fdb28b (diff) | |
| download | linux-e18504a4d378b4c9e1ee522ae7fc18cac8b1fc82.tar.gz linux-e18504a4d378b4c9e1ee522ae7fc18cac8b1fc82.zip | |
io_uring/napi: clean up list traversal with list_for_each_entry_safe()
Switch both loops to the standard list_for_each_entry_safe() pattern and
remove the explanatory comment.
Signed-off-by: Anvik Loitongbam <permissiontogallop@gmail.com>
Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
Link: https://patch.msgid.link/20261029144745.23792-1-permissiontogallop@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | io_uring/napi.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/io_uring/napi.c b/io_uring/napi.c index 7e698720cd51..d299c89cfc3d 100644 --- a/io_uring/napi.c +++ b/io_uring/napi.c @@ -110,16 +110,10 @@ static int __io_napi_del_id(struct io_ring_ctx *ctx, unsigned int napi_id) static void __io_napi_remove_stale(struct io_ring_ctx *ctx) { - struct io_napi_entry *e; + struct io_napi_entry *e, *next; guard(spinlock)(&ctx->napi_lock); - /* - * list_for_each_entry_safe() is not required as long as: - * 1. list_del_rcu() does not reset the deleted node next pointer - * 2. kfree_rcu() delays the memory freeing until the next quiescent - * state - */ - list_for_each_entry(e, &ctx->napi_list, list) { + list_for_each_entry_safe(e, next, &ctx->napi_list, list) { if (time_after(jiffies, READ_ONCE(e->timeout))) { list_del_rcu(&e->list); hash_del_rcu(&e->node); @@ -264,10 +258,10 @@ void io_napi_init(struct io_ring_ctx *ctx) */ void io_napi_free(struct io_ring_ctx *ctx) { - struct io_napi_entry *e; + struct io_napi_entry *e, *next; guard(spinlock)(&ctx->napi_lock); - list_for_each_entry(e, &ctx->napi_list, list) { + list_for_each_entry_safe(e, next, &ctx->napi_list, list) { hash_del_rcu(&e->node); kfree_rcu(e, rcu); } |