diff options
| author | Amir Goldstein <amir73il@gmail.com> | 2026-10-17 18:51:03 +0200 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2026-10-30 16:11:46 +0100 |
| commit | 8457ca071faba9dec2dde99f78da9c5af289e955 (patch) | |
| tree | 86d32e4eaa08934cc35c015b0aaa31ab2d11ec8f | |
| parent | 3a00ecc89069ea5222f6b02916e9783c6817c7c7 (diff) | |
| download | linux-8457ca071faba9dec2dde99f78da9c5af289e955.tar.gz linux-8457ca071faba9dec2dde99f78da9c5af289e955.zip | |
selftests/ovl: fix detached layer mountinfo expectations
set_layers_via_detached_mount_fds was copied from the attached-fd test
and still looks for /tmp paths. Detached open_tree() layers are recorded
by d_path() as upperdir=/upper, workdir=/work, and lowerdir+=/ and
datadir+=/ for each cloned directory. The test has failed since it was
added.
Reported-by: Disha Goel <disgoel@linux.ibm.com>
Link: https://lore.kernel.org/linux-unionfs/20260924112858.51392-2-disgoel@linux.ibm.com
Fixes: ccc829b15d48a ("selftests: add tests for using detached mount with overlayfs")
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Link: https://patch.msgid.link/20261017165103.2450042-1-amir73il@gmail.com
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
| -rw-r--r-- | tools/testing/selftests/filesystems/overlayfs/set_layers_via_fds.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/tools/testing/selftests/filesystems/overlayfs/set_layers_via_fds.c b/tools/testing/selftests/filesystems/overlayfs/set_layers_via_fds.c index 7a293544233d..83bbacb2550f 100644 --- a/tools/testing/selftests/filesystems/overlayfs/set_layers_via_fds.c +++ b/tools/testing/selftests/filesystems/overlayfs/set_layers_via_fds.c @@ -686,23 +686,23 @@ TEST_F(set_layers_via_fds, set_layers_via_detached_mount_fds) while (getline(&line, &len, f_mountinfo) != -1) { char *haystack = line; - if (strstr(haystack, "workdir=/tmp/w")) + if (strstr(haystack, "workdir=/work")) layers_found[0] = true; - if (strstr(haystack, "upperdir=/tmp/u")) + if (strstr(haystack, "upperdir=/upper")) layers_found[1] = true; - if (strstr(haystack, "lowerdir+=/tmp/l1")) + if (strstr(haystack, "lowerdir+=/")) layers_found[2] = true; - if (strstr(haystack, "lowerdir+=/tmp/l2")) + if (strstr(haystack, "lowerdir+=/")) layers_found[3] = true; - if (strstr(haystack, "lowerdir+=/tmp/l3")) + if (strstr(haystack, "lowerdir+=/")) layers_found[4] = true; - if (strstr(haystack, "lowerdir+=/tmp/l4")) + if (strstr(haystack, "lowerdir+=/")) layers_found[5] = true; - if (strstr(haystack, "datadir+=/tmp/d1")) + if (strstr(haystack, "datadir+=/")) layers_found[6] = true; - if (strstr(haystack, "datadir+=/tmp/d2")) + if (strstr(haystack, "datadir+=/")) layers_found[7] = true; - if (strstr(haystack, "datadir+=/tmp/d3")) + if (strstr(haystack, "datadir+=/")) layers_found[8] = true; } free(line); |