summaryrefslogtreecommitdiff
path: root/tools/testing/selftests/bpf/progs/refcounted_kptr_fail.c
blob: e80f78fae2276cff0ee3cde0e733703adb9c3cc8 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
// SPDX-License-Identifier: GPL-2.0
#include <vmlinux.h>
#include <bpf/bpf_tracing.h>
#include <bpf/bpf_helpers.h>
#include <bpf/bpf_core_read.h>
#include "bpf_experimental.h"
#include "bpf_misc.h"

struct node_acquire {
	long key;
	long data;
	struct bpf_rb_node node;
	struct bpf_refcount refcount;
};

struct node_refcounted {
	long key;
	struct bpf_list_node list;
	struct bpf_refcount refcount;
};

struct node_refcount_only {
	long key;
	struct bpf_refcount refcount;
};

struct map_value_refcount_only {
	struct node_refcount_only __kptr *node;
};

struct rcu_graph_node {
	struct bpf_rb_node node;
	long data;
};

struct rcu_graph_node *just_here_because_btf_bug;

struct map_value_rcu_graph {
	struct rcu_graph_node __kptr *node;
};

extern void bpf_rcu_read_lock(void) __ksym;
extern void bpf_rcu_read_unlock(void) __ksym;

#define private(name) SEC(".data." #name) __hidden __attribute__((aligned(8)))
private(A) struct bpf_spin_lock glock;
private(A) struct bpf_rb_root groot __contains(node_acquire, node);
private(B) struct bpf_spin_lock lock;
private(B) struct bpf_list_head head __contains(node_refcounted, list);
private(C) struct bpf_spin_lock graph_lock;
private(C) struct bpf_rb_root graph_root __contains(rcu_graph_node, node);

struct {
	__uint(type, BPF_MAP_TYPE_ARRAY);
	__type(key, int);
	__type(value, struct map_value_refcount_only);
	__uint(max_entries, 1);
} stashed_refcount_only SEC(".maps");

struct {
	__uint(type, BPF_MAP_TYPE_ARRAY);
	__type(key, int);
	__type(value, struct map_value_rcu_graph);
	__uint(max_entries, 1);
} stashed_rcu_graph SEC(".maps");

static bool less(struct bpf_rb_node *a, const struct bpf_rb_node *b)
{
	struct node_acquire *node_a;
	struct node_acquire *node_b;

	node_a = container_of(a, struct node_acquire, node);
	node_b = container_of(b, struct node_acquire, node);

	return node_a->key < node_b->key;
}

SEC("?tc")
__failure __msg("Unreleased reference id=4 alloc_insn={{[0-9]+}}")
long rbtree_refcounted_node_ref_escapes(void *ctx)
{
	struct node_acquire *n, *m;

	n = bpf_obj_new(typeof(*n));
	if (!n)
		return 1;

	bpf_spin_lock(&glock);
	bpf_rbtree_add(&groot, &n->node, less);
	/* m becomes an owning ref but is never drop'd or added to a tree */
	m = bpf_refcount_acquire(n);
	bpf_spin_unlock(&glock);
	if (!m)
		return 2;

	m->key = 2;
	return 0;
}

SEC("?tc")
__failure __msg("Possibly NULL pointer passed to trusted R1")
__msg("requires a non-NULL value of type (void *)")
long refcount_acquire_maybe_null(void *ctx)
{
	struct node_acquire *n, *m;

	n = bpf_obj_new(typeof(*n));
	/* Intentionally not testing !n
	 * it's MAYBE_NULL for refcount_acquire
	 */
	m = bpf_refcount_acquire(n);
	if (m)
		bpf_obj_drop(m);
	if (n)
		bpf_obj_drop(n);

	return 0;
}

SEC("?tc")
__failure __msg("R1 type=ctx expected=ptr_, rcu_ptr_, ptr_, rcu_ptr_")
__msg("type ctx, but this argument accepts ptr_, rcu_ptr_, ptr_, rcu_ptr_")
long refcount_acquire_non_object(void *ctx)
{
	return bpf_refcount_acquire(ctx) != NULL;
}

SEC("?syscall")
__failure __msg("Possibly NULL pointer passed to trusted R1")
long refcount_acquire_rcu_map_kptr_unchecked_drop(void *ctx)
{
	struct map_value_refcount_only *mapval;
	struct node_refcount_only *tmp, *n, *m;
	int idx = 0;

	/* Force Clang to emit complete BTF for struct node_refcount_only. */
	tmp = bpf_obj_new(typeof(*tmp));
	if (!tmp)
		return 3;
	bpf_obj_drop(tmp);

	mapval = bpf_map_lookup_elem(&stashed_refcount_only, &idx);
	if (!mapval)
		return 1;

	bpf_rcu_read_lock();
	n = mapval->node;
	if (!n) {
		bpf_rcu_read_unlock();
		return 2;
	}
	m = bpf_refcount_acquire(n);
	bpf_rcu_read_unlock();

	bpf_obj_drop(m);

	return 0;
}

SEC("?syscall")
__failure
__msg("R2 type=untrusted_ptr_ expected=ptr_, rcu_ptr_, ptr_, rcu_ptr_")
long rbtree_remove_after_rcu_unlock(void *ctx)
{
	struct map_value_rcu_graph *mapval;
	struct bpf_rb_node *rb_node;
	struct rcu_graph_node *node;
	int idx = 0;

	mapval = bpf_map_lookup_elem(&stashed_rcu_graph, &idx);
	if (!mapval)
		return 0;

	bpf_rcu_read_lock();
	node = mapval->node;
	if (!node) {
		bpf_rcu_read_unlock();
		return 0;
	}
	bpf_rcu_read_unlock();

	bpf_spin_lock(&graph_lock);
	rb_node = bpf_rbtree_remove(&graph_root, &node->node);
	bpf_spin_unlock(&graph_lock);
	if (rb_node)
		bpf_obj_drop(container_of(rb_node, struct rcu_graph_node, node));

	return 0;
}

SEC("?syscall")
__failure __msg("R1 type=untrusted_ptr_ expected=ptr_, rcu_ptr_, ptr_, rcu_ptr_")
long refcount_acquire_after_rcu_unlock(void *ctx)
{
	struct map_value_refcount_only *mapval;
	struct node_refcount_only *node, *ref;
	int idx = 0;

	mapval = bpf_map_lookup_elem(&stashed_refcount_only, &idx);
	if (!mapval)
		return 0;

	bpf_rcu_read_lock();
	node = mapval->node;
	if (!node) {
		bpf_rcu_read_unlock();
		return 0;
	}
	bpf_rcu_read_unlock();

	ref = bpf_refcount_acquire(node);
	if (ref)
		bpf_obj_drop(ref);

	return 0;
}

SEC("?syscall")
__failure __msg("invalid mem access 'scalar'")
long graph_kptr_after_spin_unlock(void *ctx)
{
	struct map_value_rcu_graph *mapval;
	struct rcu_graph_node *node;
	int idx = 0;

	mapval = bpf_map_lookup_elem(&stashed_rcu_graph, &idx);
	if (!mapval)
		return 0;

	bpf_spin_lock(&graph_lock);
	node = mapval->node;
	if (!node) {
		bpf_spin_unlock(&graph_lock);
		return 0;
	}
	bpf_spin_unlock(&graph_lock);

	return node->data;
}

SEC("?tc")
__failure __msg("Unreleased reference id=3 alloc_insn={{[0-9]+}}")
long rbtree_refcounted_node_ref_escapes_owning_input(void *ctx)
{
	struct node_acquire *n, *m;

	n = bpf_obj_new(typeof(*n));
	if (!n)
		return 1;

	/* m becomes an owning ref but is never drop'd or added to a tree */
	m = bpf_refcount_acquire(n);
	m->key = 2;

	bpf_spin_lock(&glock);
	bpf_rbtree_add(&groot, &n->node, less);
	bpf_spin_unlock(&glock);

	return 0;
}

SEC("?tc")
__failure __msg("dereference of modified ptr_ ptr R1")
long refcount_acquire_list_node_offset(void *ctx)
{
	struct node_refcounted *node, *base, *ref;
	struct bpf_list_node *list_node;

	node = bpf_obj_new(typeof(*node));
	if (!node)
		return 1;

	bpf_spin_lock(&lock);
	bpf_list_push_front(&head, &node->list);
	list_node = bpf_list_pop_front(&head);
	bpf_spin_unlock(&lock);
	if (!list_node)
		return 2;

	base = container_of(list_node, struct node_refcounted, list);
	ref = bpf_refcount_acquire(list_node);
	if (ref)
		bpf_obj_drop(ref);
	bpf_obj_drop(base);
	return 0;
}

SEC("?fentry.s/" SYS_PREFIX "sys_getpgid")
__failure __msg("function calls are not allowed while holding a lock")
int BPF_PROG(rbtree_fail_sleepable_lock_across_rcu,
	     struct file *file, struct kobject *kobj,
	     struct bin_attribute *bin_attr, char *buf, loff_t off, size_t len)
{
	struct node_acquire *n;

	n = bpf_obj_new(typeof(*n));
	if (!n)
		return 0;

	/* spin_{lock,unlock} are in different RCU CS */
	bpf_rcu_read_lock();
	bpf_spin_lock(&glock);
	bpf_rbtree_add(&groot, &n->node, less);
	bpf_rcu_read_unlock();

	bpf_rcu_read_lock();
	bpf_spin_unlock(&glock);
	bpf_rcu_read_unlock();

	return 0;
}

char _license[] SEC("license") = "GPL";