1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
|
// SPDX-License-Identifier: GPL-2.0
/*
* Copyright 2026 Google LLC
*
* KUnit tests for the reset controller.
*
* The test cases cover the following scenarios:
*
* - Basic: Verifies that a consumer can acquire a reset control via
* fwnode and perform reset, assert, deassert, status, release, and
* acquire operations.
*
* - Use After Unregister: Verifies that after the supplier unregisters
* the reset_controller_dev while a consumer still holds a reset_control
* handle, subsequent consumer operations fail safely with -ENODEV.
*
* - Concurrent Unregister: Verifies that unregistering the
* reset_controller_dev concurrently with an in-flight reset operation
* waits for the active operation to complete before returning.
*/
#include <kunit/fwnode.h>
#include <kunit/test.h>
#include <linux/completion.h>
#include <linux/fwnode.h>
#include <linux/iopoll.h>
#include <linux/kthread.h>
#include <linux/property.h>
#include <linux/reset-controller.h>
#include <linux/reset.h>
#include <linux/sched/task.h>
struct reset_test_context {
struct fwnode_handle *supp_fwnode;
struct fwnode_handle *cons_fwnode;
struct reset_controller_dev rcdev;
bool rcdev_registered;
struct reset_control *rstc;
int reset_count;
int assert_count;
int deassert_count;
int status_count;
void *priv;
};
static int reset_test_op_reset(struct reset_controller_dev *rcdev,
unsigned long id)
{
struct reset_test_context *ctx = container_of(rcdev, typeof(*ctx), rcdev);
ctx->reset_count++;
return 0;
}
static int reset_test_op_assert(struct reset_controller_dev *rcdev,
unsigned long id)
{
struct reset_test_context *ctx = container_of(rcdev, typeof(*ctx), rcdev);
ctx->assert_count++;
return 0;
}
static int reset_test_op_deassert(struct reset_controller_dev *rcdev,
unsigned long id)
{
struct reset_test_context *ctx = container_of(rcdev, typeof(*ctx), rcdev);
ctx->deassert_count++;
return 0;
}
static int reset_test_op_status(struct reset_controller_dev *rcdev,
unsigned long id)
{
struct reset_test_context *ctx = container_of(rcdev, typeof(*ctx), rcdev);
ctx->status_count++;
return 0;
}
static const struct reset_control_ops reset_test_ops = {
.reset = reset_test_op_reset,
.assert = reset_test_op_assert,
.deassert = reset_test_op_deassert,
.status = reset_test_op_status,
};
static int reset_test_init(struct kunit *test)
{
static const struct property_entry supp_props[] = {
PROPERTY_ENTRY_U32("#reset-cells", 1),
{}
};
static const struct software_node supp_swnode = {
.name = "reset-test-supplier",
.properties = supp_props,
};
static const struct software_node_ref_args refs[] = {
SOFTWARE_NODE_REFERENCE(&supp_swnode, 0),
};
static const struct property_entry cons_props[] = {
PROPERTY_ENTRY_REF_ARRAY("resets", refs),
{}
};
struct reset_test_context *ctx;
int ret;
ctx = kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL);
KUNIT_ASSERT_NOT_NULL(test, ctx);
test->priv = ctx;
ctx->supp_fwnode = kunit_software_node_register(test, &supp_swnode);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx->supp_fwnode);
ctx->cons_fwnode = kunit_fwnode_create_software_node(test, cons_props,
NULL);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx->cons_fwnode);
ctx->rcdev.ops = &reset_test_ops;
ctx->rcdev.nr_resets = 1;
ctx->rcdev.fwnode = ctx->supp_fwnode;
ret = reset_controller_register(&ctx->rcdev);
KUNIT_ASSERT_EQ(test, ret, 0);
ctx->rcdev_registered = true;
ctx->rstc = __fwnode_reset_control_get(ctx->cons_fwnode, NULL, 0,
RESET_CONTROL_EXCLUSIVE);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx->rstc);
return 0;
}
static void reset_test_exit(struct kunit *test)
{
struct reset_test_context *ctx = test->priv;
if (!ctx)
return;
reset_control_put(ctx->rstc);
if (ctx->rcdev_registered)
reset_controller_unregister(&ctx->rcdev);
}
static void reset_test_basic(struct kunit *test)
{
struct reset_test_context *ctx = test->priv;
struct reset_control *rstc = ctx->rstc;
KUNIT_EXPECT_EQ(test, ctx->reset_count, 0);
KUNIT_EXPECT_EQ(test, reset_control_reset(rstc), 0);
KUNIT_EXPECT_EQ(test, ctx->reset_count, 1);
KUNIT_EXPECT_EQ(test, ctx->assert_count, 0);
KUNIT_EXPECT_EQ(test, reset_control_assert(rstc), 0);
KUNIT_EXPECT_EQ(test, ctx->assert_count, 1);
KUNIT_EXPECT_EQ(test, ctx->deassert_count, 0);
KUNIT_EXPECT_EQ(test, reset_control_deassert(rstc), 0);
KUNIT_EXPECT_EQ(test, ctx->deassert_count, 1);
KUNIT_EXPECT_EQ(test, ctx->status_count, 0);
KUNIT_EXPECT_EQ(test, reset_control_status(rstc), 0);
KUNIT_EXPECT_EQ(test, ctx->status_count, 1);
reset_control_release(rstc);
KUNIT_EXPECT_EQ(test, reset_control_acquire(rstc), 0);
}
static void reset_test_use_after_unregister(struct kunit *test)
{
struct reset_test_context *ctx = test->priv;
struct reset_control *rstc = ctx->rstc;
KUNIT_EXPECT_EQ(test, ctx->reset_count, 0);
KUNIT_EXPECT_EQ(test, reset_control_reset(rstc), 0);
KUNIT_EXPECT_EQ(test, ctx->reset_count, 1);
/* Unregister supplier while consumer still holds rstc. */
reset_controller_unregister(&ctx->rcdev);
ctx->rcdev_registered = false;
KUNIT_EXPECT_EQ(test, ctx->reset_count, 1);
KUNIT_EXPECT_EQ(test, reset_control_reset(rstc), -ENODEV);
KUNIT_EXPECT_EQ(test, ctx->reset_count, 1);
KUNIT_EXPECT_EQ(test, reset_control_assert(rstc), -ENODEV);
KUNIT_EXPECT_EQ(test, reset_control_deassert(rstc), -ENODEV);
KUNIT_EXPECT_EQ(test, reset_control_status(rstc), -ENODEV);
reset_control_release(rstc);
KUNIT_EXPECT_EQ(test, reset_control_acquire(rstc), -ENODEV);
}
struct test_concurrent_unregister_context {
struct kunit *test;
struct completion started, enter;
struct task_struct *thread;
union {
/* Used by test supplier. */
struct completion exited;
/* Used by test consumer. */
struct {
struct completion entered, exit;
int expected_ret;
};
};
};
static int test_concurrent_unregister_supplier(void *data)
{
struct test_concurrent_unregister_context *ctx = data;
struct reset_test_context *rtc = ctx->test->priv;
complete(&ctx->started);
if (wait_for_completion_interruptible(&ctx->enter))
return 0;
reset_controller_unregister(&rtc->rcdev);
rtc->rcdev_registered = false;
complete(&ctx->exited);
return 0;
}
static int test_concurrent_unregister_consumer(void *data)
{
struct test_concurrent_unregister_context *ctx = data;
struct reset_test_context *rtc = ctx->test->priv;
int ret;
complete(&ctx->started);
if (wait_for_completion_interruptible(&ctx->enter))
return 0;
ret = reset_control_reset(rtc->rstc);
KUNIT_EXPECT_EQ(ctx->test, ret, ctx->expected_ret);
return 0;
}
static int
reset_test_concurrent_unregister_op_reset(struct reset_controller_dev *rcdev,
unsigned long id)
{
struct reset_test_context *rtc = container_of(rcdev, typeof(*rtc), rcdev);
struct test_concurrent_unregister_context *ctx = rtc->priv;
rtc->reset_count++;
complete(&ctx->entered);
wait_for_completion_interruptible(&ctx->exit);
return ctx->expected_ret;
}
static const struct reset_control_ops reset_test_concurrent_unregister_ops = {
.reset = reset_test_concurrent_unregister_op_reset,
};
static void reset_test_concurrent_unregister(struct kunit *test)
{
struct reset_test_context *rtc = test->priv;
struct test_concurrent_unregister_context *ctx;
int i, ret, val;
rtc->rcdev.ops = &reset_test_concurrent_unregister_ops;
ctx = kunit_kmalloc_array(test, 3, sizeof(*ctx), GFP_KERNEL);
KUNIT_ASSERT_NOT_NULL(test, ctx);
for (i = 0; i < 3; ++i) {
ctx[i].test = test;
init_completion(&ctx[i].started);
init_completion(&ctx[i].enter);
if (i == 0) {
init_completion(&ctx[i].exited);
ctx[i].thread = kthread_run(
test_concurrent_unregister_supplier, ctx + i,
"supplier%d", i);
} else {
init_completion(&ctx[i].entered);
init_completion(&ctx[i].exit);
ctx[i].thread = kthread_run(
test_concurrent_unregister_consumer, ctx + i,
"consumer%d", i);
}
if (IS_ERR(ctx[i].thread)) {
ret = PTR_ERR(ctx[i].thread);
while (i--)
kthread_stop_put(ctx[i].thread);
KUNIT_ASSERT_EQ(test, ret, 0);
}
get_task_struct(ctx[i].thread);
wait_for_completion(&ctx[i].started);
}
rtc->priv = &ctx[1];
ctx[1].expected_ret = 0x12345678;
/* consumer1 enters reset(). */
KUNIT_EXPECT_EQ(test, rtc->reset_count, 0);
complete(&ctx[1].enter);
wait_for_completion(&ctx[1].entered);
KUNIT_EXPECT_EQ(test, rtc->reset_count, 1);
/* supplier0 unregisters. */
complete(&ctx[0].enter);
ret = read_poll_timeout(reset_control_status, val, val == -ENODEV,
1000, 100000, false, rtc->rstc);
if (ret) {
for (i = 2; i >= 0; --i)
kthread_stop_put(ctx[i].thread);
KUNIT_ASSERT_EQ(test, ret, 0);
}
/* supplier0 can't exit. It's waiting for all consumers. */
ret = wait_for_completion_timeout(&ctx[0].exited, msecs_to_jiffies(100));
KUNIT_EXPECT_EQ(test, ret, 0);
ctx[2].expected_ret = -ENODEV;
/* consumer2 must see -ENODEV. */
complete(&ctx[2].enter);
kthread_stop_put(ctx[2].thread);
/* consumer1 exits reset(). */
complete(&ctx[1].exit);
kthread_stop_put(ctx[1].thread);
kthread_stop_put(ctx[0].thread);
/* Subsequent access must see -ENODEV. */
KUNIT_EXPECT_EQ(test, reset_control_reset(rtc->rstc), -ENODEV);
}
static struct kunit_case reset_test_cases[] = {
KUNIT_CASE(reset_test_basic),
KUNIT_CASE(reset_test_use_after_unregister),
KUNIT_CASE(reset_test_concurrent_unregister),
{}
};
static struct kunit_suite reset_test_suite = {
.name = "reset_test",
.test_cases = reset_test_cases,
.init = reset_test_init,
.exit = reset_test_exit,
};
kunit_test_suite(reset_test_suite);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Tzung-Bi Shih <tzungbi@kernel.org>");
MODULE_DESCRIPTION("KUnit tests for the reset controller");
|