1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
|
// SPDX-License-Identifier: GPL-2.0-or-later
/*
* ChromeOS EC driver for charge control
*
* Copyright (C) 2024 Thomas Weißschuh <linux@weissschuh.net>
*/
#include <acpi/battery.h>
#include <linux/container_of.h>
#include <linux/dmi.h>
#include <linux/lockdep.h>
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/platform_data/cros_ec_commands.h>
#include <linux/platform_data/cros_ec_proto.h>
#include <linux/platform_device.h>
#include <linux/types.h>
#define EC_CHARGE_CONTROL_BEHAVIOURS (BIT(POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO) | \
BIT(POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE) | \
BIT(POWER_SUPPLY_CHARGE_BEHAVIOUR_FORCE_DISCHARGE))
/*
* Semantics of data *returned* from the EC API and Linux sysfs differ
* slightly:
* - EC sustainer off is lower=upper=-1
* - Linux "no limit" is start=0, end=100
* Also the v1 API can not return any data.
*
* While the sustainer is active the EC may report IDLE or DISCHARGE as the
* current charge-control mode; that is an internal hold/discharge step, not a
* Linux inhibit-charge / force-discharge request. Valid sustainer limits are
* therefore adopted as AUTO with the reported thresholds.
*
* Sysfs reads come from a driver-side cache. On probe, command versions that
* support GET (v2+) are initialized from the EC so firmware or firmware-setup
* programmed limits and modes are preserved (unlike earlier behaviour that
* always forced AUTO with no limits). v1 still forces a well-known EC state.
* Subsequent sysfs writes keep the cache and EC in sync; changes that bypass
* the driver are not reflected until the next probe.
*/
struct cros_chctl_priv {
struct device *dev;
struct cros_ec_device *cros_ec;
struct acpi_battery_hook battery_hook;
struct power_supply *hooked_battery;
u8 cmd_version;
const struct power_supply_ext *psy_ext;
struct mutex lock; /* protects fields below and cros_ec */
enum power_supply_charge_behaviour current_behaviour;
u8 current_start_threshold, current_end_threshold;
};
static int cros_chctl_send_charge_control_cmd(struct cros_ec_device *cros_ec,
u8 cmd_version,
struct ec_params_charge_control *req,
struct ec_response_charge_control *resp)
{
static const u8 outsizes[] = {
[1] = offsetof(struct ec_params_charge_control, cmd),
[2] = sizeof(struct ec_params_charge_control),
[3] = sizeof(struct ec_params_charge_control),
};
size_t insize = resp ? sizeof(*resp) : 0;
int ret;
if (resp)
*resp = (struct ec_response_charge_control){};
ret = cros_ec_cmd(cros_ec, cmd_version, EC_CMD_CHARGE_CONTROL, req,
outsizes[cmd_version], resp, insize);
if (ret < 0)
return ret;
return 0;
}
static int cros_chctl_configure_ec(struct cros_chctl_priv *priv)
{
struct ec_params_charge_control req = {};
lockdep_assert_held(&priv->lock);
req.cmd = EC_CHARGE_CONTROL_CMD_SET;
switch (priv->current_behaviour) {
case POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO:
req.mode = CHARGE_CONTROL_NORMAL;
break;
case POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE:
req.mode = CHARGE_CONTROL_IDLE;
break;
case POWER_SUPPLY_CHARGE_BEHAVIOUR_FORCE_DISCHARGE:
req.mode = CHARGE_CONTROL_DISCHARGE;
break;
default:
return -EINVAL;
}
if (priv->current_behaviour == POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO &&
!(priv->current_start_threshold == 0 && priv->current_end_threshold == 100)) {
req.sustain_soc.lower = priv->current_start_threshold;
req.sustain_soc.upper = priv->current_end_threshold;
} else {
/* Disable charging limits */
req.sustain_soc.lower = -1;
req.sustain_soc.upper = -1;
}
return cros_chctl_send_charge_control_cmd(priv->cros_ec, priv->cmd_version,
&req, NULL);
}
static int cros_chctl_get_ec_status(struct cros_chctl_priv *priv,
struct ec_response_charge_control *resp)
{
struct ec_params_charge_control req = {
.cmd = EC_CHARGE_CONTROL_CMD_GET,
};
return cros_chctl_send_charge_control_cmd(priv->cros_ec, priv->cmd_version,
&req, resp);
}
static void cros_chctl_set_default_state(struct cros_chctl_priv *priv)
{
lockdep_assert_held(&priv->lock);
priv->current_behaviour = POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO;
priv->current_start_threshold = 0;
priv->current_end_threshold = 100;
}
static bool cros_chctl_sustainer_limits_valid(s8 lower, s8 upper)
{
return lower >= 0 && upper >= 0 && lower <= 100 && upper <= 100 && lower <= upper;
}
static int cros_chctl_adopt_ec_mode(struct cros_chctl_priv *priv, u32 mode)
{
lockdep_assert_held(&priv->lock);
switch (mode) {
case CHARGE_CONTROL_NORMAL:
priv->current_behaviour = POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO;
return 0;
case CHARGE_CONTROL_IDLE:
priv->current_behaviour = POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE;
return 0;
case CHARGE_CONTROL_DISCHARGE:
priv->current_behaviour = POWER_SUPPLY_CHARGE_BEHAVIOUR_FORCE_DISCHARGE;
return 0;
default:
dev_warn(priv->dev, "unknown charge control mode %u\n", mode);
return -EINVAL;
}
}
static int cros_chctl_init_state(struct cros_chctl_priv *priv)
{
struct ec_response_charge_control resp;
s8 lower, upper;
int ret;
guard(mutex)(&priv->lock);
/* v1 cannot report current state; force a well-known EC configuration. */
if (priv->cmd_version < 2) {
cros_chctl_set_default_state(priv);
return cros_chctl_configure_ec(priv);
}
ret = cros_chctl_get_ec_status(priv, &resp);
if (ret < 0) {
dev_warn(priv->dev,
"failed to read EC charge state (%pe), applying defaults\n",
ERR_PTR(ret));
goto defaults;
}
lower = resp.sustain_soc.lower;
upper = resp.sustain_soc.upper;
/*
* Valid sustainer limits mean "auto with thresholds". The EC mode may
* be IDLE/DISCHARGE while the sustainer holds or bleeds SoC; do not
* expose that as inhibit-charge / force-discharge.
*/
if (cros_chctl_sustainer_limits_valid(lower, upper)) {
priv->current_behaviour = POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO;
priv->current_start_threshold = lower;
priv->current_end_threshold = upper;
} else {
ret = cros_chctl_adopt_ec_mode(priv, resp.mode);
if (ret < 0)
goto defaults;
/*
* Sustainer off is lower=upper=-1 → Linux "no limit" (0/100).
* Any other non-valid pair is unexpected; remap, warn, and
* push the cleaned state back to the EC.
*/
priv->current_start_threshold = 0;
priv->current_end_threshold = 100;
if (!(lower == -1 && upper == -1)) {
dev_warn(priv->dev,
"invalid EC sustainer limits (%d/%d), treating as no limit\n",
lower, upper);
return cros_chctl_configure_ec(priv);
}
}
dev_dbg(priv->dev,
"adopted EC charge state: behaviour=%d start=%u end=%u (ec mode=%u)\n",
priv->current_behaviour, priv->current_start_threshold,
priv->current_end_threshold, resp.mode);
return 0;
defaults:
cros_chctl_set_default_state(priv);
return cros_chctl_configure_ec(priv);
}
static int cros_chctl_psy_ext_get_prop(struct power_supply *psy,
const struct power_supply_ext *ext,
void *data,
enum power_supply_property psp,
union power_supply_propval *val)
{
struct cros_chctl_priv *priv = data;
switch (psp) {
case POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD:
val->intval = priv->current_start_threshold;
return 0;
case POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD:
val->intval = priv->current_end_threshold;
return 0;
case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR:
val->intval = priv->current_behaviour;
return 0;
default:
return -EINVAL;
}
}
static int cros_chctl_psy_ext_set_threshold(struct cros_chctl_priv *priv,
enum power_supply_property psp,
int val)
{
int ret;
if (val < 0 || val > 100)
return -EINVAL;
if (psp == POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD) {
/* Start threshold is not exposed, use fixed value */
if (priv->cmd_version == 2)
priv->current_start_threshold = val == 100 ? 0 : val;
if (val < priv->current_start_threshold)
return -EINVAL;
priv->current_end_threshold = val;
} else {
if (val > priv->current_end_threshold)
return -EINVAL;
priv->current_start_threshold = val;
}
if (priv->current_behaviour == POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO) {
ret = cros_chctl_configure_ec(priv);
if (ret < 0)
return ret;
}
return 0;
}
static int cros_chctl_psy_ext_set_prop(struct power_supply *psy,
const struct power_supply_ext *ext,
void *data,
enum power_supply_property psp,
const union power_supply_propval *val)
{
struct cros_chctl_priv *priv = data;
int ret;
guard(mutex)(&priv->lock);
switch (psp) {
case POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD:
case POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD:
return cros_chctl_psy_ext_set_threshold(priv, psp, val->intval);
case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR:
priv->current_behaviour = val->intval;
ret = cros_chctl_configure_ec(priv);
if (ret < 0)
return ret;
return 0;
default:
return -EINVAL;
}
}
static int cros_chctl_psy_prop_is_writeable(struct power_supply *psy,
const struct power_supply_ext *ext,
void *data,
enum power_supply_property psp)
{
return true;
}
#define DEFINE_CROS_CHCTL_POWER_SUPPLY_EXTENSION(_name, ...) \
static const enum power_supply_property _name ## _props[] = { \
__VA_ARGS__, \
}; \
\
static const struct power_supply_ext _name = { \
.name = "cros-charge-control", \
.properties = _name ## _props, \
.num_properties = ARRAY_SIZE(_name ## _props), \
.charge_behaviours = EC_CHARGE_CONTROL_BEHAVIOURS, \
.get_property = cros_chctl_psy_ext_get_prop, \
.set_property = cros_chctl_psy_ext_set_prop, \
.property_is_writeable = cros_chctl_psy_prop_is_writeable, \
}
DEFINE_CROS_CHCTL_POWER_SUPPLY_EXTENSION(cros_chctl_psy_ext_v1,
POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR
);
DEFINE_CROS_CHCTL_POWER_SUPPLY_EXTENSION(cros_chctl_psy_ext_v2,
POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR,
POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD
);
DEFINE_CROS_CHCTL_POWER_SUPPLY_EXTENSION(cros_chctl_psy_ext_v3,
POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR,
POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD,
POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD
);
static int cros_chctl_add_battery(struct power_supply *battery, struct acpi_battery_hook *hook)
{
struct cros_chctl_priv *priv = container_of(hook, struct cros_chctl_priv, battery_hook);
if (priv->hooked_battery)
return 0;
priv->hooked_battery = battery;
return power_supply_register_extension(battery, priv->psy_ext, priv->dev, priv);
}
static int cros_chctl_remove_battery(struct power_supply *battery, struct acpi_battery_hook *hook)
{
struct cros_chctl_priv *priv = container_of(hook, struct cros_chctl_priv, battery_hook);
if (priv->hooked_battery == battery) {
power_supply_unregister_extension(battery, priv->psy_ext);
priv->hooked_battery = NULL;
}
return 0;
}
static bool probe_with_fwk_charge_control;
module_param(probe_with_fwk_charge_control, bool, 0644);
MODULE_PARM_DESC(probe_with_fwk_charge_control,
"Probe the driver in the presence of the custom Framework EC charge control");
static int cros_chctl_fwk_charge_control_versions(struct cros_ec_device *cros_ec)
{
if (!dmi_match(DMI_SYS_VENDOR, "Framework"))
return 0;
return cros_ec_get_cmd_versions(cros_ec, 0x3E03 /* FW_EC_CMD_CHARGE_LIMIT */);
}
static int cros_chctl_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
struct cros_ec_device *cros_ec = ec_dev->ec_dev;
struct cros_chctl_priv *priv;
int ret;
ret = cros_chctl_fwk_charge_control_versions(cros_ec);
if (ret < 0)
return ret;
if (ret > 0 && !probe_with_fwk_charge_control) {
dev_info(dev, "Framework charge control detected, preventing load\n");
return -ENODEV;
}
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
ret = devm_mutex_init(dev, &priv->lock);
if (ret)
return ret;
ret = cros_ec_get_cmd_versions(cros_ec, EC_CMD_CHARGE_CONTROL);
if (ret < 0)
return ret;
else if (ret & EC_VER_MASK(3))
priv->cmd_version = 3;
else if (ret & EC_VER_MASK(2))
priv->cmd_version = 2;
else if (ret & EC_VER_MASK(1))
priv->cmd_version = 1;
else
return -ENODEV;
dev_dbg(dev, "Command version: %u\n", (unsigned int)priv->cmd_version);
priv->dev = dev;
priv->cros_ec = cros_ec;
if (priv->cmd_version == 1)
priv->psy_ext = &cros_chctl_psy_ext_v1;
else if (priv->cmd_version == 2)
priv->psy_ext = &cros_chctl_psy_ext_v2;
else
priv->psy_ext = &cros_chctl_psy_ext_v3;
priv->battery_hook.name = dev_name(dev);
priv->battery_hook.add_battery = cros_chctl_add_battery;
priv->battery_hook.remove_battery = cros_chctl_remove_battery;
ret = cros_chctl_init_state(priv);
if (ret < 0)
return ret;
return devm_battery_hook_register(dev, &priv->battery_hook);
}
static const struct platform_device_id cros_chctl_id[] = {
{ .name = "cros-charge-control" },
{ }
};
MODULE_DEVICE_TABLE(platform, cros_chctl_id);
static struct platform_driver cros_chctl_driver = {
.driver.name = "cros-charge-control",
.probe = cros_chctl_probe,
.id_table = cros_chctl_id,
};
module_platform_driver(cros_chctl_driver);
MODULE_DESCRIPTION("ChromeOS EC charge control");
MODULE_AUTHOR("Thomas Weißschuh <linux@weissschuh.net>");
MODULE_LICENSE("GPL");
|