diff options
| author | Eduard Zingerman <eddyz87@gmail.com> | 2026-09-16 09:53:03 -0700 |
|---|---|---|
| committer | Eduard Zingerman <eddyz87@gmail.com> | 2026-09-17 10:56:08 -0700 |
| commit | 9e4188d7a411103b6b1406dd67d55c3bbb637551 (patch) | |
| tree | 1e34a68c54b0fa496a5f32c441a9d6c608b9acb6 /tools/perf/scripts/python/stackcollapse.py | |
| parent | ee363e055895364039bf28348ff13c615afad4ba (diff) | |
| parent | a452e729b7be317837bb2157d5d88aa3de9873e6 (diff) | |
| download | linux-next-9e4188d7a411103b6b1406dd67d55c3bbb637551.tar.gz linux-next-9e4188d7a411103b6b1406dd67d55c3bbb637551.zip | |
Merge branch 'fix-global-subprog-verification-context'
Kumar Kartikeya Dwivedi says:
====================
Fix global subprog verification context
Global subprogs can be invoked in both sleepable and non-sleepable
contexts, but are verified based on context assumptions for the program
type as a whole and not the precise context in which they are invoked.
Nicholas identified that this can violate verifier safety assumptions.
Verify global subprogs once for each observed sleepability context and add
workqueue callback regression tests.
Changelog:
----------
v2 -> v3
v2: https://lore.kernel.org/bpf/20260905051224.2325381-1-memxor@gmail.com
* Clarify that globals are checked only in contexts from which they are
reached, with two passes only when both contexts occur. (Alexei)
* Implement in_sleepable_context() as !in_rcu_cs(). (Alexei, Eduard)
* Keep the original subprogram traversal order and repeat until all
called contexts have been verified. (Eduard)
* Explain why instruction accounting needs the saved total and why the
exception callback uses the main program's context. (Eduard)
* Rename the do_check_common() parameter to is_sleepable. (BPF CI)
* Preserve the harmless global calls with __weak __noinline and check
their instruction totals across both contexts. Drop the redundant
task-work global RCU test and retain the review acknowledgment. (Eduard)
v1 -> v2
v1: https://lore.kernel.org/bpf/20260905034018.2095649-1-memxor@gmail.com
* Preserve the harmless global subprog calls in the positive test with
barrier() so LLVM cannot eliminate the intended coverage.
* Return zero explicitly from workqueue callbacks after global subprog calls.
* Document cumulative instruction accounting across verification contexts.
* Fix BPF multi-line comment formatting.
====================
Link: https://patch.msgid.link/20260914131923.2544250-1-memxor@gmail.com
Signed-off-by: Eduard Zingerman <eddyz87@gmail.com>
Diffstat (limited to 'tools/perf/scripts/python/stackcollapse.py')
0 files changed, 0 insertions, 0 deletions
