diff options
| author | Michael S. Tsirkin <mst@redhat.com> | 2026-09-12 06:30:18 -0400 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2026-09-12 11:58:57 -0400 |
| commit | 2a12d96dd863cb23eadf07d8845e961580b5fcdf (patch) | |
| tree | a4ec2c3da327a8416cd55ab6b2f0f3a3015f86b9 /tools/perf/scripts/python/bin/stackcollapse-report | |
| parent | dd75508e6fe77116589c49658d0d18897688dc0b (diff) | |
| download | linux-next-2a12d96dd863cb23eadf07d8845e961580b5fcdf.tar.gz linux-next-2a12d96dd863cb23eadf07d8845e961580b5fcdf.zip | |
virtio_pci_modern: move avq cleanup from reset to del_vqs
vp_modern_avq_cleanup() detaches unused buffers from the admin
virtqueue. Calling it from vp_reset() is incorrect:
virtqueue_get_buf in the avq interrupt handler can race with
virtqueue_detach_unused_buf in cleanup, and get_buf after
detach is not documented as valid.
The root cause is that detaching buffers does not belong in
reset at all - reset quiesces the device, while cleanup belongs
where the virtqueue is about to be destroyed, from del_vqs.
Reported-by: Sashiko <sashiko-bot@kernel.org>
Link: https://lore.kernel.org/virtualization/20260911125745.E0A2F1F00899@smtp.kernel.org/
Fixes: 4c3b54af907e ("virtio_pci_modern: use completion instead of busy loop to wait on admin cmd result")
Cc: Jiri Pirko <jiri@resnulli.us>
Assisted-by: LLM
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Message-ID: <21fe35ad7b66e2c30dbdba6fe4df4824d1c0db66.1789204858.git.mst@redhat.com>
Diffstat (limited to 'tools/perf/scripts/python/bin/stackcollapse-report')
0 files changed, 0 insertions, 0 deletions