diff options
| author | Orgad Shaneh <orgads@gmail.com> | 2026-09-01 19:30:27 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-09-10 17:07:55 +0200 |
| commit | 4c7a1b9f1f1979f2b3b69428ada12680695159c2 (patch) | |
| tree | 163daa6c65f8cbed3b1c1615073c908f2e68d0c8 /tools/lib/python/kdoc/python_version.py | |
| parent | 29480b05e6e226594dc11ccf2a036fbd5cdd0e42 (diff) | |
| download | linux-next-4c7a1b9f1f1979f2b3b69428ada12680695159c2.tar.gz linux-next-4c7a1b9f1f1979f2b3b69428ada12680695159c2.zip | |
usb: octeon-hcd: fix the FIFO-flush timeout computation
cvmx_wait_tx_rx() computes its 100us deadline from
(u64)octeon_get_clock_rate - the address of the function, not its
return value; the parentheses have been missing since the
CVMX_WAIT_FOR_FIELD32 macro became a function. The cast makes it
compile silently, and the resulting deadline is effectively infinite.
On a healthy controller the flush bit clears on the first read and
nothing is noticed. On a controller whose PHY did not come up (for
example when the reference-clock configuration is wrong for the board),
txfflsh/rxfflsh never clear and probe spins forever in __delay() -
observed as a hard hang with a soft-lockup splat on a CN5020 board,
where the board watchdog then resets the system with no console output.
Call the function, restoring the 100us timeout the code always
intended.
Fixes: 3e195a80e096 ("Staging: octeon-usb: Replaces CVMX_WAIT_FOR_FIELD32 macro with a function")
Cc: stable@vger.kernel.org
Assisted-by: Claude:claude-opus-5
Signed-off-by: Orgad Shaneh <orgads@gmail.com>
Link: https://patch.msgid.link/20260901193100.1352110-1-orgads@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'tools/lib/python/kdoc/python_version.py')
0 files changed, 0 insertions, 0 deletions
