diff options
| author | Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> | 2023-03-24 09:44:06 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-03-29 15:03:08 +0100 |
| commit | e506b2bd1d2e9daaedd1db2ef9868f7b8c4c86c3 (patch) | |
| tree | ad208fe6f6501121bc63b39a35f7f0ba3bf6d5cc /sound/soc/codecs/rt715.h | |
| parent | 278432084b093f7257cf96c75bb33f155e4a8232 (diff) | |
| download | linux-next-e506b2bd1d2e9daaedd1db2ef9868f7b8c4c86c3.tar.gz linux-next-e506b2bd1d2e9daaedd1db2ef9868f7b8c4c86c3.zip | |
ASoC: codecs: rt715: simplify set_stream
Using a dynamic allocation to store a single pointer is not very
efficient/useful.
Worse, the memory is released in the SoundWire stream.c file, but
still accessed in the DAI shutdown, leading to kmemleak reports.
And last the API requires the previous stream information to be
cleared when the argument is NULL.
Simplify the code to address all 3 problems.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20230324014408.1677505-12-yung-chuan.liao@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/rt715.h')
| -rw-r--r-- | sound/soc/codecs/rt715.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/sound/soc/codecs/rt715.h b/sound/soc/codecs/rt715.h index 25dba61f1760..17a8d041c1c3 100644 --- a/sound/soc/codecs/rt715.h +++ b/sound/soc/codecs/rt715.h @@ -27,10 +27,6 @@ struct rt715_priv { unsigned int kctl_8ch_vol_ori[8]; }; -struct sdw_stream_data { - struct sdw_stream_runtime *sdw_stream; -}; - /* NID */ #define RT715_AUDIO_FUNCTION_GROUP 0x01 #define RT715_MIC_ADC 0x07 |