diff options
| author | Waiman Long <longman@redhat.com> | 2026-10-19 14:10:13 -0400 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2026-10-19 13:08:19 -1000 |
| commit | 53bbfb33b1f4fd669c5bffcb7670c4099ecbb225 (patch) | |
| tree | c293358b51dac8782c096cd94491795e8726ee48 /scripts/Makefile.thinlto | |
| parent | 46b885416c27214072272b85adb898ed91801062 (diff) | |
| download | linux-next-53bbfb33b1f4fd669c5bffcb7670c4099ecbb225.tar.gz linux-next-53bbfb33b1f4fd669c5bffcb7670c4099ecbb225.zip | |
cgroup/cpuset: Consolidate isolated_cpus_can_update() into prstate_housekeeping_conflict()
The isolated_cpus_can_update() and prstate_housekeeping_conflict() are
checking different aspects of upcoming cpumask changes that may conflict
with the current setting of the housekeeping cpumasks. There are places
where both are called together. There are also places where only one
of them is called. That inconsistency can contribute to missing check
where invalid cpumask changes may be allowed to move forward.
Fix that by consolidating isolated_cpus_can_update() into
prstate_housekeeping_conflict() and call prstate_housekeeping_conflict()
in all the places where either one of them or both are called. The
exception is the validate_partition() function where the
prstate_housekeeping_conflict() call is removed. It is because
validate_partition() is called only from partition_cpus_change()
where prstate_housekeeping_conflict() will be called from either
remote_cpus_update() or update_parent_effective_cpumask() with
partcmd_update if not for partition invalidatation or disablement.
Now prstate_housekeeping_conflict() will be called in the following
locations:
- when a partition is enabled in remote_partition_enable() or in
update_parent_effective_cpumask() with partcmd_enable*.
- when a cpumask is updated in remote_cpus_update() or in
update_parent_effective_cpumask() with partcmd_update.
- when a partition state changes from root to isolated or vice versa
in update_prstate().
Fixes: 4a74e418881f ("cgroup/cpuset: Check partition conflict with housekeeping setup")
Fixes: 103b08709e8a ("cgroup/cpuset: Fail if isolated and nohz_full don't leave any housekeeping")
Reviewed-by: Guopeng Zhang <zhangguopeng@kylinos.cn>
Signed-off-by: Waiman Long <longman@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'scripts/Makefile.thinlto')
0 files changed, 0 insertions, 0 deletions
