diff options
| author | FUJITA Tomonori <fujita.tomonori@gmail.com> | 2026-10-01 21:31:03 +0900 |
|---|---|---|
| committer | Miguel Ojeda <ojeda@kernel.org> | 2026-10-01 21:52:45 +0200 |
| commit | 951d09ca450ca76a695016ea76c3fa653bd20439 (patch) | |
| tree | 4fa1fbaa7f7be7f8e978e4e8260445cebd828656 /rust | |
| parent | e91836593fbfb0014c290e9a0bbd86d0b98c1d2f (diff) | |
| download | linux-next-951d09ca450ca76a695016ea76c3fa653bd20439.tar.gz linux-next-951d09ca450ca76a695016ea76c3fa653bd20439.zip | |
rust: bug: pass TAINT_WARN to warn_slowpath_fmt() on UML
On UML, `warn_flags!` calls `warn_slowpath_fmt()` directly. Its third
argument is a taint number, but `warn_on!` passes its bug flags there.
As a result, `add_taint()` gets 2304 instead of 9 (`TAINT_WARN`). The
warning is not recorded: `/proc/sys/kernel/tainted` stays 0 after
`warn_on!` fires, where it should be 512. It also causes an
out-of-bounds write in `add_taint()`.
Pass `TAINT_WARN` directly, as C does on UML.
Cc: stable@vger.kernel.org
Fixes: dff64b072708 ("rust: Add warn_on macro")
Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
Link: https://patch.msgid.link/20261001123103.2198104-1-tomo@flapping.org
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Diffstat (limited to 'rust')
| -rw-r--r-- | rust/kernel/bug.rs | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/rust/kernel/bug.rs b/rust/kernel/bug.rs index 3566f0234ca4..af8eba4563de 100644 --- a/rust/kernel/bug.rs +++ b/rust/kernel/bug.rs @@ -85,6 +85,7 @@ macro_rules! warn_flags { ($file:expr, $flags:expr) => { if false { _ = $file; + _ = $flags; } // SAFETY: It is always safe to call `warn_slowpath_fmt()` @@ -93,7 +94,7 @@ macro_rules! warn_flags { $crate::bindings::warn_slowpath_fmt( $crate::str::CStrExt::as_char_ptr($crate::c_str!(::core::file!())), line!() as $crate::ffi::c_int, - $flags as $crate::ffi::c_uint, + $crate::bindings::TAINT_WARN, ::core::ptr::null(), ); } |