diff options
| author | Minhong He <heminhong@kylinos.cn> | 2026-07-20 15:25:18 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-07-23 09:17:36 -0700 |
| commit | d9a33cadc70a94c1582f65e6042e81027cd200c6 (patch) | |
| tree | da4c9b3839676e4c7f350248e864c97d26e36e77 /net | |
| parent | c3f2fc231a39e29fe9f0adc14a3ecc3c1260d3c5 (diff) | |
| download | linux-next-d9a33cadc70a94c1582f65e6042e81027cd200c6.tar.gz linux-next-d9a33cadc70a94c1582f65e6042e81027cd200c6.zip | |
mctp: check register_netdevice_notifier() error in mctp_device_init()
mctp_device_init() handles errors from rtnl_af_register() and
rtnl_register_many(), but ignores the return value of
register_netdevice_notifier(). If notifier registration fails, init can
still return success while the module is only partially initialized.
Check the notifier registration error and fail module init early.
Fixes: 583be982d934 ("mctp: Add device handling and netlink interface")
Signed-off-by: Minhong He <heminhong@kylinos.cn>
Link: https://patch.msgid.link/20260720072518.112614-1-heminhong@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/mctp/device.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/mctp/device.c b/net/mctp/device.c index 2c84df674669..822120e860c8 100644 --- a/net/mctp/device.c +++ b/net/mctp/device.c @@ -536,7 +536,9 @@ int __init mctp_device_init(void) { int err; - register_netdevice_notifier(&mctp_dev_nb); + err = register_netdevice_notifier(&mctp_dev_nb); + if (err) + return err; err = rtnl_af_register(&mctp_af_ops); if (err) |