diff options
| author | Breno Leitao <leitao@debian.org> | 2026-06-29 04:45:41 -0700 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-06-30 17:15:11 -0700 |
| commit | 84c0ff1efb62b0053aa265b8deb13842f68f1a74 (patch) | |
| tree | 673145e29d78ea9da200bb04e2baa04b163356dd /net | |
| parent | 09f7a613a14fd6683e8e4437c97bde0f1ca7062c (diff) | |
| download | linux-next-84c0ff1efb62b0053aa265b8deb13842f68f1a74.tar.gz linux-next-84c0ff1efb62b0053aa265b8deb13842f68f1a74.zip | |
netpoll: do not warn when the best-effort pool refill fails
refill_skbs() tops up the per-netpoll skb pool with GFP_ATOMIC and
simply stops on the first allocation failure, leaving the pool partially
filled; a later refill tops it up once memory frees up. The allocation
failing is therefore an expected and fully handled condition, but
without __GFP_NOWARN the page allocator emits a warn_alloc() splat with
a full stack trace on every miss.
Pass __GFP_NOWARN so the best-effort refill stays quiet, mirroring the
same change in netconsole's find_skb().
Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20260629-netpoll_no_warn-v1-2-f380f0b2cd0c@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/core/netpoll.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 229dde818ab3..85aa51350881 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -221,7 +221,7 @@ static void refill_skbs(struct netpoll *np) skb_pool = &np->skb_pool; while (READ_ONCE(skb_pool->qlen) < MAX_SKBS) { - skb = alloc_skb(MAX_SKB_SIZE, GFP_ATOMIC); + skb = alloc_skb(MAX_SKB_SIZE, GFP_ATOMIC | __GFP_NOWARN); if (!skb) break; |