diff options
| author | Nikolay Aleksandrov <razor@blackwall.org> | 2026-09-14 13:52:58 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-09-15 18:31:57 -0700 |
| commit | 2842ce397dd09882530b42f7fdb0c855767eb24e (patch) | |
| tree | 75078af382d48e3dfd8d383a4ce85ee9346cdf7e /net/ipv4 | |
| parent | f0ef4b1eaed000a304726a43091588e8426ba08a (diff) | |
| download | linux-next-2842ce397dd09882530b42f7fdb0c855767eb24e.tar.gz linux-next-2842ce397dd09882530b42f7fdb0c855767eb24e.zip | |
net: bridge: vlan: fix bugs caused by switchdev deletion errors
Allowing switchdev to prevent vlan deletion and error out in __vlan_del
could cause multiple different issues - inconsistent state, memory leaks
when flushing, NULL pointer dereference on bridge error when flushing.
It doesn't make sense to allow it to stop __vlan_del, so log the error
and continue with software vlan deletion. This is also consistent with
8021q behaviour.
Suggested-by: Ido Schimmel <idosch@nvidia.com>
Fixes: bf361ad38165 ("net: bridge: check __vlan_vid_del for error")
Fixes: 5454f5c28eca ("net: bridge: vlan: check for errors from __vlan_del in __vlan_flush")
Fixes: 2594e9064a57 ("bridge: vlan: add per-vlan struct and move to rhashtables")
Fixes: 9c86ce2c1ae3 ("net: bridge: Notify about bridge VLANs")
Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/20260914105258.3436918-1-razor@blackwall.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/ipv4')
0 files changed, 0 insertions, 0 deletions