diff options
| author | Qingfang Deng <dqfext@gmail.com> | 2026-03-06 17:36:49 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-03-09 19:07:38 -0700 |
| commit | abb0eb0b033a0a8980eb9215e02626e4801ead3f (patch) | |
| tree | 61202f608353a206112e6fa8acfcd32a6c58deeb /net/atm | |
| parent | 58e4d35ae7b9325ab622bbcc34312b17af425c8f (diff) | |
| download | linux-next-abb0eb0b033a0a8980eb9215e02626e4801ead3f.tar.gz linux-next-abb0eb0b033a0a8980eb9215e02626e4801ead3f.zip | |
ppp: simplify input error handling
Currently, ppp_input_error() indicates an error by allocating a 0-length
skb and calling ppp_do_recv(). It takes an error code argument, which is
stored in skb->cb, but not used by ppp_receive_frame().
Simplify the error handling by removing the unused parameter and the
unnecessary skb allocation. Instead, call ppp_receive_error() directly
from ppp_input_error() under the recv lock, and the length check in
ppp_receive_frame() can be removed.
Signed-off-by: Qingfang Deng <dqfext@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/atm')
| -rw-r--r-- | net/atm/pppoatm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/atm/pppoatm.c b/net/atm/pppoatm.c index 2574aae3e066..e3c422dc533a 100644 --- a/net/atm/pppoatm.c +++ b/net/atm/pppoatm.c @@ -228,7 +228,7 @@ static void pppoatm_push(struct atm_vcc *atmvcc, struct sk_buff *skb) error: kfree_skb(skb); - ppp_input_error(&pvcc->chan, 0); + ppp_input_error(&pvcc->chan); } static int pppoatm_may_send(struct pppoatm_vcc *pvcc, int size) |