Merge tag 'firewire-updates-7.4' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394

Pull firewire updates from Takashi Sakamoto:

 - Guarantee asynchronous packet and transaction callbacks in process
   context

   Both the 1394 OHCI driver and the core transaction layer have been
   changed to guarantee that asynchronous packet and transaction
   callbacks are invoked in process context. In v6.17, the execution
   context depended on the transaction destination: callbacks for
   transactions destined for remote nodes were invoked from a workqueue,
   whereas callbacks for transactions destined for the local node or
   terminated due to internal errors were invoked in the transaction
   initiator's context.

   All such callbacks are now guaranteed to execute in process context,
   eliminating the need to account for different execution contexts when
   implementing callback functions.

 - Fill kerneldoc for transaction layer

   The above change guarantees a consistent execution context for packet
   and transaction callbacks, making it possible to document their
   execution context in kerneldoc.

 - Enable compiler-based context analysis for the transaction layer

   The core transaction layer is sufficiently complex that
   compiler-based context analysis can help detect invalid call paths.

 - Fix a reference count leak in the cdev layer

   A reference count leak was reported when a user space application
   delegated isochronous resource management. This issue has now been
   fixed.

 - Add KUnit tests for the configuration ROM parser and generator

   In recent years, questions have been raised about how the
   configuration ROM parser and generator handle boundary conditions and
   edge cases. KUnit tests have been added to verify their behavior in
   these situations. KUNIT_STATIC_STUB_REDIRECT is used to stub the
   transaction responder so that it returns the configuration ROM
   contents.

 - Misc fixes for kerneldoc and nosy-dump application

* tag 'firewire-updates-7.4' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394: (88 commits)
  firewire: core: replace drain_workqueue() with flush_workqueue()
  firewire: core: adjust context_unsafe() usage for lockdep checks
  firewire: core: invoke packet callback from workqueue when removing card instance
  firewire: core: use designated initializer for dummy driver on card removal
  firewire: core: use context analysis to check lock state when scheduling error callbacks
  firewire: core: check precondition when scheduling error callbacks
  firewire: core: use workqueue to cancel all pending transactions on card removal
  firewire: core: reuse helper function for scheduling error callbacks
  firewire: core: don't disable error work for transaction
  firewire: core: use release/acquire pair when replacing underlying driver on card removal
  firewire: core: add kerneldoc for inbound transaction-related symbols
  firewire: core: add kerneldoc for outbound transaction-related symbols
  firewire: core: use appropriate spinlock variants for transaction-related locks
  firewire: core: narrow the card lock scope when accessing node_id
  firewire: core: use context analysis annotations and lockdep checks for topology map lock
  firewire: core: use context analysis annotations and lockdep checks for split timeout lock
  firewire: core: use context analysis annotations and lockdep checks for transactions lock
  firewire: core: enable context analysis for transaction layer
  firewire: core: add might_sleep() checks to transaction layer
  firewire: core: fulfill kerneldoc for fw_cancel_transaction()
  ...

1 files changed, 2 insertions, 2 deletions

diff --git a/include/uapi/linux/firewire-cdev.h b/include/uapi/linux/firewire-cdev.h
index 05e3aa8fa8bc..4f83d6babc92 100644
--- a/include/uapi/linux/firewire-cdev.h
+++ b/include/uapi/linux/firewire-cdev.h
@@ -293,7 +293,7 @@ struct fw_cdev_event_request3 {
 /**
  * struct fw_cdev_event_iso_interrupt - Sent when an iso packet was completed
  * @closure:	See &fw_cdev_event_common;
- *		set by %FW_CDEV_CREATE_ISO_CONTEXT ioctl
+ *		set by %FW_CDEV_IOC_CREATE_ISO_CONTEXT ioctl
  * @type:	See &fw_cdev_event_common; always %FW_CDEV_EVENT_ISO_INTERRUPT
  * @cycle:	Cycle counter of the last completed packet
  * @header_length: Total length of following headers, in bytes
@@ -353,7 +353,7 @@ struct fw_cdev_event_iso_interrupt {
 /**
  * struct fw_cdev_event_iso_interrupt_mc - An iso buffer chunk was completed
  * @closure:	See &fw_cdev_event_common;
- *		set by %FW_CDEV_CREATE_ISO_CONTEXT ioctl
+ *		set by %FW_CDEV_IOC_CREATE_ISO_CONTEXT ioctl
  * @type:	%FW_CDEV_EVENT_ISO_INTERRUPT_MULTICHANNEL
  * @completed:	Offset into the receive buffer; data before this offset is valid
  *