diff options
| author | David Howells <dhowells@redhat.com> | 2024-12-16 20:41:00 +0000 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-12-20 22:34:04 +0100 |
| commit | 627cf645277b6f8e6128e2c86907a81970bce87a (patch) | |
| tree | ee9daab1e41458bc995d2d58076e40338065db31 /fs/netfs/read_retry.c | |
| parent | 31fc366aa7aa911ebc0744e99c82caee4e97315a (diff) | |
| download | linux-next-627cf645277b6f8e6128e2c86907a81970bce87a.tar.gz linux-next-627cf645277b6f8e6128e2c86907a81970bce87a.zip | |
netfs: Don't use bh spinlock
All the accessing of the subrequest lists is now done in process context,
possibly in a workqueue, but not now in a BH context, so we don't need the
lock against BH interference when taking the netfs_io_request::lock
spinlock.
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/20241216204124.3752367-11-dhowells@redhat.com
cc: Jeff Layton <jlayton@kernel.org>
cc: linux-cachefs@redhat.com
cc: linux-fsdevel@vger.kernel.org
cc: linux-mm@kvack.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/netfs/read_retry.c')
| -rw-r--r-- | fs/netfs/read_retry.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/netfs/read_retry.c b/fs/netfs/read_retry.c index a2021efa44c0..a33bd06e80f8 100644 --- a/fs/netfs/read_retry.c +++ b/fs/netfs/read_retry.c @@ -142,12 +142,12 @@ static void netfs_retry_read_subrequests(struct netfs_io_request *rreq) __clear_bit(NETFS_SREQ_MADE_PROGRESS, &subreq->flags); subreq->retry_count++; - spin_lock_bh(&rreq->lock); + spin_lock(&rreq->lock); list_add_tail(&subreq->rreq_link, &rreq->subrequests); subreq->prev_donated += rreq->prev_donated; rreq->prev_donated = 0; trace_netfs_sreq(subreq, netfs_sreq_trace_retry); - spin_unlock_bh(&rreq->lock); + spin_unlock(&rreq->lock); BUG_ON(!len); @@ -217,9 +217,9 @@ abandon: __clear_bit(NETFS_SREQ_FAILED, &subreq->flags); __clear_bit(NETFS_SREQ_NEED_RETRY, &subreq->flags); } - spin_lock_bh(&rreq->lock); + spin_lock(&rreq->lock); list_splice_tail_init(&queue, &rreq->subrequests); - spin_unlock_bh(&rreq->lock); + spin_unlock(&rreq->lock); } /* |