diff options
| author | Rosen Penev <rosenp@gmail.com> | 2026-07-12 14:37:26 -0700 |
|---|---|---|
| committer | Damien Le Moal <dlemoal@kernel.org> | 2026-07-13 14:32:11 +0900 |
| commit | 4bbc16a353a98023e5ddfca7c1fc0e49971cf4d0 (patch) | |
| tree | a32b1532b545013a18d4a7b0578685b84d968b85 /drivers | |
| parent | 793bf193b18e9bff6c4280268bbffd16a5b533e5 (diff) | |
| download | linux-next-4bbc16a353a98023e5ddfca7c1fc0e49971cf4d0.tar.gz linux-next-4bbc16a353a98023e5ddfca7c1fc0e49971cf4d0.zip | |
ata: sata_dwc_460ex: enable SATA interrupts only after IRQ handler is registered
sata_dwc_enable_interrupts() is called before platform_get_irq() and
ata_host_activate(), leaving the SATA controller's interrupt mask
enabled without a registered handler. If a later step fails (irq
request, phy init, etc.) or if the controller asserts an interrupt
during probe, the irq line may fire with no handler, causing a
spurious interrupt storm.
Move sata_dwc_enable_interrupts() after ata_host_activate() so that
interrupts are only unmasked once the handler is registered and the
core is fully initialized.
Fixes: 62936009f35a ("[libata] Add 460EX on-chip SATA driver, sata_dwc_460ex")
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/ata/sata_dwc_460ex.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 4fc22ce4bd9a..e10eeb8ca030 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -1169,9 +1169,6 @@ static int sata_dwc_probe(struct platform_device *ofdev) /* Save dev for later use in dev_xxx() routines */ hsdev->dev = dev; - /* Enable SATA Interrupts */ - sata_dwc_enable_interrupts(hsdev); - /* Get SATA interrupt number */ irq = irq_of_parse_and_map(np, 0); if (!irq) { @@ -1204,6 +1201,8 @@ static int sata_dwc_probe(struct platform_device *ofdev) if (err) dev_err(dev, "failed to activate host"); + /* Enable SATA Interrupts */ + sata_dwc_enable_interrupts(hsdev); return 0; error_out: |