diff options
| author | Felix Gu <ustc.gu@gmail.com> | 2026-05-10 01:55:37 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-05-16 11:27:08 +0900 |
| commit | 496ba79b9496b8b3747cbc764ebd33ee7325e806 (patch) | |
| tree | 6ede6741b355868512e20bbaab3ff72b11aa5efb /drivers | |
| parent | 5e121a81667a83e9a01d62b429e340f5a4a84abc (diff) | |
| download | linux-next-496ba79b9496b8b3747cbc764ebd33ee7325e806.tar.gz linux-next-496ba79b9496b8b3747cbc764ebd33ee7325e806.zip | |
spi: mtk-snfi: Fix resource leak in mtk_snand_read_page_cache()
When DMA read times out in mtk_snand_read_page_cache(), the original code
erroneously jumped to cleanup label which skips DMA unmapping and ECC
disable, causing a resource leak.
Fixes: 764f1b748164 ("spi: add driver for MTK SPI NAND Flash Interface")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260510-snfi-v1-1-bc375cf1af8e@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/spi/spi-mtk-snfi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-mtk-snfi.c b/drivers/spi/spi-mtk-snfi.c index e616e6800e92..6e96e50fedad 100644 --- a/drivers/spi/spi-mtk-snfi.c +++ b/drivers/spi/spi-mtk-snfi.c @@ -961,7 +961,7 @@ static int mtk_snand_read_page_cache(struct mtk_snand *snf, &snf->op_done, usecs_to_jiffies(SNFI_POLL_INTERVAL))) { dev_err(snf->dev, "DMA timed out for reading from cache.\n"); ret = -ETIMEDOUT; - goto cleanup; + goto cleanup2; } // Wait for BUS_SEC_CNTR returning expected value |