summaryrefslogtreecommitdiff
path: root/drivers/video/fbdev/intelfb
diff options
context:
space:
mode:
authorThomas Zimmermann <tzimmermann@suse.de>2023-09-27 09:26:54 +0200
committerThomas Zimmermann <tzimmermann@suse.de>2023-10-19 12:55:40 +0200
commit68deeb025fbfb809aabfecf84331c8d872a101a3 (patch)
tree8f6f47d6904471e9ff2d0199fd104edb5713fc64 /drivers/video/fbdev/intelfb
parent80ac1058e4c0acc4303fd8bb42d5702433867359 (diff)
downloadlinux-next-68deeb025fbfb809aabfecf84331c8d872a101a3.tar.gz
linux-next-68deeb025fbfb809aabfecf84331c8d872a101a3.zip
fbdev/intelfb: Initialize fb_ops to fbdev I/O-memory helpers
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the callbacks being NULL for a default implementation to be invoked; hence requiring the I/O helpers to be built in any case. Setting all callbacks in all drivers explicitly will allow to make the I/O helpers optional. This benefits systems that do not use these functions. No functional changes. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Javier Martinez Canillas <javierm@redhat.com> Cc: Maik Broemme <mbroemme@libmpq.org> Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-22-tzimmermann@suse.de
Diffstat (limited to 'drivers/video/fbdev/intelfb')
-rw-r--r--drivers/video/fbdev/intelfb/intelfbdrv.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c
index 3d334f171959..d29d80a16295 100644
--- a/drivers/video/fbdev/intelfb/intelfbdrv.c
+++ b/drivers/video/fbdev/intelfb/intelfbdrv.c
@@ -198,6 +198,7 @@ static const struct fb_ops intel_fb_ops = {
.owner = THIS_MODULE,
.fb_open = intelfb_open,
.fb_release = intelfb_release,
+ __FB_DEFAULT_IOMEM_OPS_RDWR,
.fb_check_var = intelfb_check_var,
.fb_set_par = intelfb_set_par,
.fb_setcolreg = intelfb_setcolreg,
@@ -208,7 +209,8 @@ static const struct fb_ops intel_fb_ops = {
.fb_imageblit = intelfb_imageblit,
.fb_cursor = intelfb_cursor,
.fb_sync = intelfb_sync,
- .fb_ioctl = intelfb_ioctl
+ .fb_ioctl = intelfb_ioctl,
+ __FB_DEFAULT_IOMEM_OPS_MMAP,
};
/* PCI driver module table */