diff options
| author | Thorsten Blum <thorsten.blum@linux.dev> | 2025-10-17 11:19:23 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-10-22 10:58:31 +0200 |
| commit | 8ad194699fc17bec5307b59d36676f43ea460b05 (patch) | |
| tree | 98e37f9c737c7dbb08bd717c93e21bbd086256c4 /drivers/usb/usbip | |
| parent | 071786e27d81d3e8ae11f078357c9373fc4ce2e8 (diff) | |
| download | linux-next-8ad194699fc17bec5307b59d36676f43ea460b05.tar.gz linux-next-8ad194699fc17bec5307b59d36676f43ea460b05.zip | |
usbip: Use min to simplify stub_send_ret_submit
Use min() to improve stub_send_ret_submit(). Change the local variable
'size' from 'int' to 'unsigned int' to prevent a signedness error and to
match the resulting type.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20251017091923.1694-2-thorsten.blum@linux.dev
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/usbip')
| -rw-r--r-- | drivers/usb/usbip/stub_tx.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/usb/usbip/stub_tx.c b/drivers/usb/usbip/stub_tx.c index 7eb2e074012a..55919c3762ba 100644 --- a/drivers/usb/usbip/stub_tx.c +++ b/drivers/usb/usbip/stub_tx.c @@ -4,6 +4,7 @@ */ #include <linux/kthread.h> +#include <linux/minmax.h> #include <linux/socket.h> #include <linux/scatterlist.h> @@ -239,17 +240,13 @@ static int stub_send_ret_submit(struct stub_device *sdev) urb->actual_length > 0) { if (urb->num_sgs) { unsigned int copy = urb->actual_length; - int size; + unsigned int size; for_each_sg(urb->sg, sg, urb->num_sgs, i) { if (copy == 0) break; - if (copy < sg->length) - size = copy; - else - size = sg->length; - + size = min(copy, sg->length); iov[iovnum].iov_base = sg_virt(sg); iov[iovnum].iov_len = size; |