diff options
| author | Pengpeng Hou <pengpeng@iscas.ac.cn> | 2026-06-23 21:59:37 +0800 |
|---|---|---|
| committer | Ulf Hansson <ulfh@kernel.org> | 2026-07-13 12:13:27 +0200 |
| commit | a1d9d3b958d69a13783613304f524f489fecdd1f (patch) | |
| tree | 55b4152f7c0c5786fcd286d78797109857d14f72 /drivers/pmdomain | |
| parent | c011b7c92514196bac6746a81ae2437d264c0fe6 (diff) | |
| download | linux-next-a1d9d3b958d69a13783613304f524f489fecdd1f.tar.gz linux-next-a1d9d3b958d69a13783613304f524f489fecdd1f.zip | |
pmdomain: bcm: bcm2835: handle genpd provider registration errors
bcm2835_power_probe() initializes all power domains and then registers
the onecell genpd provider, but ignores of_genpd_add_provider_onecell()
failures. Probe can therefore return success even though no provider was
published.
Check the provider registration return value and jump to the existing
cleanup path on failure.
Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains under a new binding.")
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
Signed-off-by: Ulf Hansson <ulfh@kernel.org>
Diffstat (limited to 'drivers/pmdomain')
| -rw-r--r-- | drivers/pmdomain/bcm/bcm2835-power.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/pmdomain/bcm/bcm2835-power.c b/drivers/pmdomain/bcm/bcm2835-power.c index b76d74e3849b..68a0a7a8cee3 100644 --- a/drivers/pmdomain/bcm/bcm2835-power.c +++ b/drivers/pmdomain/bcm/bcm2835-power.c @@ -677,7 +677,12 @@ static int bcm2835_power_probe(struct platform_device *pdev) if (ret) goto fail; - of_genpd_add_provider_onecell(dev->parent->of_node, &power->pd_xlate); + ret = of_genpd_add_provider_onecell(dev->parent->of_node, + &power->pd_xlate); + if (ret) { + dev_err_probe(dev, ret, "failed to add genpd provider\n"); + goto fail; + } dev_info(dev, "Broadcom BCM2835 power domains driver"); return 0; |