diff options
| author | Xianwei Zhao <xianwei.zhao@amlogic.com> | 2025-03-03 15:53:20 +0800 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2025-03-04 09:37:33 +0100 |
| commit | c3a0b61e498e915baa7d74bacd0d20d9aa34638a (patch) | |
| tree | 09045b313aee62de360659059ef3726564e8f231 /drivers/pinctrl | |
| parent | 75f87f5d04f73645136d7a603c331d844fc5704a (diff) | |
| download | linux-next-c3a0b61e498e915baa7d74bacd0d20d9aa34638a.tar.gz linux-next-c3a0b61e498e915baa7d74bacd0d20d9aa34638a.zip | |
pinctrl: meson: fix pin input property for a4
The register of pin input attribute means the opposite.
value of reigster meaning is 1 for input and 0 for output.
So fix it.
Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
Link: https://lore.kernel.org/20250303-fix-a4-pinctl-v1-1-6579888b4272@amlogic.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
| -rw-r--r-- | drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c index a5218e8f1e03..35d5540b8eaa 100644 --- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c @@ -775,7 +775,7 @@ static int aml_gpio_get_direction(struct gpio_chip *chip, unsigned int gpio) if (ret) return ret; - return BIT(bit) & val ? GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN; + return BIT(bit) & val ? GPIO_LINE_DIRECTION_IN : GPIO_LINE_DIRECTION_OUT; } static int aml_gpio_direction_input(struct gpio_chip *chip, unsigned int gpio) @@ -785,7 +785,7 @@ static int aml_gpio_direction_input(struct gpio_chip *chip, unsigned int gpio) aml_gpio_calc_reg_and_bit(bank, AML_REG_DIR, gpio, ®, &bit); - return regmap_update_bits(bank->reg_gpio, reg, BIT(bit), 0); + return regmap_update_bits(bank->reg_gpio, reg, BIT(bit), BIT(bit)); } static int aml_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio, @@ -796,7 +796,7 @@ static int aml_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio, int ret; aml_gpio_calc_reg_and_bit(bank, AML_REG_DIR, gpio, ®, &bit); - ret = regmap_update_bits(bank->reg_gpio, reg, BIT(bit), BIT(bit)); + ret = regmap_update_bits(bank->reg_gpio, reg, BIT(bit), 0); if (ret < 0) return ret; |