diff options
| author | Shitalkumar Gandhi <shital.gandhi45@gmail.com> | 2026-05-07 19:50:24 +0530 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-05-10 10:16:58 -0700 |
| commit | a450063ef86b9967234ca1f896c0d77400c74f11 (patch) | |
| tree | e43290e5f4b474e246fb7cfc096176950ba91fa7 /drivers/net/ethernet/apm | |
| parent | 69754da484bdd9a6fc223d939298d656d7e13489 (diff) | |
| download | linux-next-a450063ef86b9967234ca1f896c0d77400c74f11.tar.gz linux-next-a450063ef86b9967234ca1f896c0d77400c74f11.zip | |
net: xgene: fix mdio_np leak in xgene_mdiobus_register()
The for_each_child_of_node() loop captures mdio_np via break,
holding the refcount. of_mdiobus_register() does not consume the
reference, so it leaks on success.
Put it after registration.
Fixes: e6ad767305eb ("drivers: net: Add APM X-Gene SoC ethernet driver support.")
Signed-off-by: Shitalkumar Gandhi <shitalkumar.gandhi@cambiumnetworks.com>
Link: https://patch.msgid.link/20260507142024.811543-1-shitalkumar.gandhi@cambiumnetworks.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/apm')
| -rw-r--r-- | drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c index b854b6b42d77..2926e1e59941 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c @@ -910,7 +910,9 @@ static int xgene_mdiobus_register(struct xgene_enet_pdata *pdata, return -ENXIO; } - return of_mdiobus_register(mdio, mdio_np); + ret = of_mdiobus_register(mdio, mdio_np); + of_node_put(mdio_np); + return ret; } /* Mask out all PHYs from auto probing. */ |