diff options
| author | Manuel Fombuena <fombuena@outlook.com> | 2026-07-02 23:31:55 +0100 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2026-07-09 10:52:02 +0100 |
| commit | dcc31246aaf0d330a3ba9a725f56c33e6d634caa (patch) | |
| tree | 8ba1ddaef87474b69872eedb3194fbc328aa9c1b /drivers/leds | |
| parent | d2ca0e2b6d6430f9c60bb2e0ee0b2b3dc4e5d86a (diff) | |
| download | linux-next-dcc31246aaf0d330a3ba9a725f56c33e6d634caa.tar.gz linux-next-dcc31246aaf0d330a3ba9a725f56c33e6d634caa.zip | |
leds: st1202: Fix spurious pattern sequence start in setup
st1202_setup() writes PATS and PATSR to the Configuration register as
its final step, which starts the hardware pattern sequencer during
device probe before any patterns have been programmed. This causes the
device to run a sequence with whatever values happen to be in the
pattern registers at the time.
Remove the write. The device reset at the start of setup restores all
registers to their power-on defaults, leaving PATS and PATSR cleared.
Fixes: 259230378c65 ("leds: Add LED1202 I2C driver")
Signed-off-by: Manuel Fombuena <fombuena@outlook.com>
Assisted-by: Claude:claude-sonnet-4-6
Link: https://patch.msgid.link/GV1PR08MB849724B0FF00255F4760FAE0C5F52@GV1PR08MB8497.eurprd08.prod.outlook.com
Signed-off-by: Lee Jones <lee@kernel.org>
Diffstat (limited to 'drivers/leds')
| -rw-r--r-- | drivers/leds/leds-st1202.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c index 3203b3768ec5..b8a571282900 100644 --- a/drivers/leds/leds-st1202.c +++ b/drivers/leds/leds-st1202.c @@ -333,11 +333,6 @@ static int st1202_setup(struct st1202_chip *chip) if (ret < 0) return ret; - ret = st1202_write_reg(chip, ST1202_CONFIG_REG, - ST1202_CONFIG_REG_PATS | ST1202_CONFIG_REG_PATSR); - if (ret < 0) - return ret; - return 0; } |