summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/msm/msm_kms.c
diff options
context:
space:
mode:
authorDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>2025-09-03 13:51:51 +0300
committerRob Clark <robin.clark@oss.qualcomm.com>2025-09-08 07:24:58 -0700
commit618c11ea0b4a7c42eee9e5699d074c79be104f60 (patch)
tree1257dede36fd116ae3d6438efb71e64b61e55470 /drivers/gpu/drm/msm/msm_kms.c
parentc94fc6d35685587aa0cb9a8d7d7062c73ab04d89 (diff)
downloadlinux-next-618c11ea0b4a7c42eee9e5699d074c79be104f60.tar.gz
linux-next-618c11ea0b4a7c42eee9e5699d074c79be104f60.zip
drm/msm: don't return NULL from msm_iommu_new()
As we've dropped no-IOMMU support, there is no reason to specially handle the no-IOMMU case inside msm_iommu_new(). Make it return -ENODEV if there is no IOMMU (instead of returning NULL) and simplify all calling sites accordingly. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Patchwork: https://patchwork.freedesktop.org/patch/672561/ Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
Diffstat (limited to 'drivers/gpu/drm/msm/msm_kms.c')
-rw-r--r--drivers/gpu/drm/msm/msm_kms.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/gpu/drm/msm/msm_kms.c b/drivers/gpu/drm/msm/msm_kms.c
index 4c4dcb095c4d..725367157d90 100644
--- a/drivers/gpu/drm/msm/msm_kms.c
+++ b/drivers/gpu/drm/msm/msm_kms.c
@@ -193,17 +193,17 @@ struct drm_gpuvm *msm_kms_init_vm(struct drm_device *dev)
*/
if (device_iommu_mapped(mdp_dev))
iommu_dev = mdp_dev;
- else
+ else if (device_iommu_mapped(mdss_dev))
iommu_dev = mdss_dev;
- mmu = msm_iommu_disp_new(iommu_dev, 0);
- if (IS_ERR(mmu))
- return ERR_CAST(mmu);
-
- if (!mmu) {
+ else {
drm_info(dev, "no IOMMU, bailing out\n");
return ERR_PTR(-ENODEV);
}
+ mmu = msm_iommu_disp_new(iommu_dev, 0);
+ if (IS_ERR(mmu))
+ return ERR_CAST(mmu);
+
vm = msm_gem_vm_create(dev, mmu, "mdp_kms",
0x1000, 0x100000000 - 0x1000, true);
if (IS_ERR(vm)) {