diff options
| author | Chen-Yu Tsai <wenst@chromium.org> | 2026-03-17 12:00:32 +0800 |
|---|---|---|
| committer | Chen-Yu Tsai <wenst@chromium.org> | 2026-03-26 14:35:18 +0800 |
| commit | e3eb0e70815cc02ea15298818e37d8b0a0930ab1 (patch) | |
| tree | 8d71003f33b8ed41886d31e0c8065180ed9a192c /drivers/gpu/drm/drm_gem_dma_helper.c | |
| parent | 1f513a3ec3a945efb30c963681ac32ac7b99928b (diff) | |
| download | linux-next-e3eb0e70815cc02ea15298818e37d8b0a0930ab1.tar.gz linux-next-e3eb0e70815cc02ea15298818e37d8b0a0930ab1.zip | |
drm/gem-dma: set VM_DONTDUMP for mmap
When the mmap function was converted from a file op to a GEM object
function in commit f5ca8eb6f9bd ("drm/cma-helper: Implement mmap as GEM
CMA object functions") some VM flags were not lifted from drm_gem_mmap():
- VM_IO
- VM_DONTEXPAND
- VM_DONTDUMP
VM_DONTEXPAND was added back in commit 59f39bfa6553 ("drm/cma-helper:
Set VM_DONTEXPAND for mmap"). VM_IO doesn't make sense since these are
memory buffers, while "IO tells people not to look at these pages
(accesses can have side effects)".
Add back VM_DONTDUMP. This matches the behavior of most other GEM
implementations.
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patch.msgid.link/20260317040034.617585-1-wenst@chromium.org
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Diffstat (limited to 'drivers/gpu/drm/drm_gem_dma_helper.c')
| -rw-r--r-- | drivers/gpu/drm/drm_gem_dma_helper.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/drm_gem_dma_helper.c b/drivers/gpu/drm/drm_gem_dma_helper.c index 70f83e464476..1c00a71ab3c9 100644 --- a/drivers/gpu/drm/drm_gem_dma_helper.c +++ b/drivers/gpu/drm/drm_gem_dma_helper.c @@ -537,7 +537,7 @@ int drm_gem_dma_mmap(struct drm_gem_dma_object *dma_obj, struct vm_area_struct * * the whole buffer. */ vma->vm_pgoff -= drm_vma_node_start(&obj->vma_node); - vm_flags_mod(vma, VM_DONTEXPAND, VM_PFNMAP); + vm_flags_mod(vma, VM_DONTDUMP | VM_DONTEXPAND, VM_PFNMAP); if (dma_obj->map_noncoherent) { vma->vm_page_prot = vm_get_page_prot(vma->vm_flags); |