diff options
| author | Rosen Penev <rosenp@gmail.com> | 2026-09-08 14:26:07 -0700 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2026-09-10 19:28:10 +0530 |
| commit | d882935a2ca4457f6f446b02d7d08134cd9d4582 (patch) | |
| tree | 2c5422cc0be2441b7361e6ec0fc1b180feb4b773 /drivers/dma | |
| parent | a72f75e1f5552df8765920b678a9037b7f31a91c (diff) | |
| download | linux-next-d882935a2ca4457f6f446b02d7d08134cd9d4582.tar.gz linux-next-d882935a2ca4457f6f446b02d7d08134cd9d4582.zip | |
dmaengine: at_hdmac: use devm_clk_get_enabled()
Replace the devm_clk_get() + clk_prepare_enable() pair with
devm_clk_get_enabled(), which handles enable/disable and the
unprepare on driver detach automatically. This lets us drop the
err_irq cleanup label and the clk_disable_unprepare() calls in
probe error paths and at_dma_remove().
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20260908212607.590224-1-rosenp@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/at_hdmac.c | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index f4d0c72787d1..cae26ea890fa 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -1994,20 +1994,16 @@ static int __init at_dma_probe(struct platform_device *pdev) atdma->dma_device.cap_mask = plat_dat->cap_mask; atdma->all_chan_mask = (1 << plat_dat->nr_channels) - 1; - atdma->clk = devm_clk_get(&pdev->dev, "dma_clk"); + atdma->clk = devm_clk_get_enabled(&pdev->dev, "dma_clk"); if (IS_ERR(atdma->clk)) return PTR_ERR(atdma->clk); - err = clk_prepare_enable(atdma->clk); - if (err) - return err; - /* force dma off, just in case */ at_dma_off(atdma); err = request_irq(irq, at_dma_interrupt, 0, "at_hdmac", atdma); if (err) - goto err_irq; + return err; platform_set_drvdata(pdev, atdma); @@ -2126,8 +2122,6 @@ err_memset_pool_create: dma_pool_destroy(atdma->lli_pool); err_desc_pool_create: free_irq(irq, atdma); -err_irq: - clk_disable_unprepare(atdma->clk); return err; } @@ -2145,8 +2139,6 @@ static void at_dma_remove(struct platform_device *pdev) at_dma_cleanup_channels(atdma); dma_pool_destroy(atdma->memset_pool); dma_pool_destroy(atdma->lli_pool); - - clk_disable_unprepare(atdma->clk); } static void at_dma_shutdown(struct platform_device *pdev) |