diff options
| author | Vinicius Costa Gomes <vinicius.gomes@intel.com> | 2026-01-21 10:34:27 -0800 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2026-02-25 16:39:17 +0530 |
| commit | caf91cdf2de8b7134749d32cd4ae5520b108abb7 (patch) | |
| tree | bdccc350ee547c99378274d005ad931c43924a18 /drivers/dma/idxd/init.c | |
| parent | 77b19d053ac2cce9e873007ad4b09f2323c93576 (diff) | |
| download | linux-next-caf91cdf2de8b7134749d32cd4ae5520b108abb7.tar.gz linux-next-caf91cdf2de8b7134749d32cd4ae5520b108abb7.zip | |
dmaengine: idxd: Fix lockdep warnings when calling idxd_device_config()
Move the check for IDXD_FLAG_CONFIGURABLE and the locking to "inside"
idxd_device_config(), as this is common to all callers, and the one
that wasn't holding the lock was an error (that was causing the
lockdep warning).
Suggested-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Link: https://patch.msgid.link/20260121-idxd-fix-flr-on-kernel-queues-v3-v3-1-7ed70658a9d1@intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/idxd/init.c')
| -rw-r--r-- | drivers/dma/idxd/init.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c index fb80803d5b57..dd32b81a3108 100644 --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -1104,12 +1104,10 @@ static void idxd_reset_done(struct pci_dev *pdev) idxd_device_config_restore(idxd, idxd->idxd_saved); /* Re-configure IDXD device if allowed. */ - if (test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags)) { - rc = idxd_device_config(idxd); - if (rc < 0) { - dev_err(dev, "HALT: %s config fails\n", idxd_name); - goto out; - } + rc = idxd_device_config(idxd); + if (rc < 0) { + dev_err(dev, "HALT: %s config fails\n", idxd_name); + goto out; } /* Bind IDXD device to driver. */ |