summaryrefslogtreecommitdiff
path: root/drivers/dibs/dibs_loopback.c
diff options
context:
space:
mode:
authorDust Li <dust.li@linux.alibaba.com>2026-07-07 15:43:18 +0800
committerPaolo Abeni <pabeni@redhat.com>2026-07-09 12:44:00 +0200
commit78237e3c0720fcc6eb9b87e90fd70f63eeca886f (patch)
tree626153581998515ed11af65563ec77f9bbc52837 /drivers/dibs/dibs_loopback.c
parentfabb881df322da25442f98d23f5fa371e3c78ec4 (diff)
downloadlinux-next-78237e3c0720fcc6eb9b87e90fd70f63eeca886f.tar.gz
linux-next-78237e3c0720fcc6eb9b87e90fd70f63eeca886f.zip
dibs: loopback: validate offset and size in move_data()
The loopback move_data() performs a memcpy into the registered DMB without checking whether offset + size exceeds the DMB length. Unlike real ISM hardware, which enforces memory region bounds natively, the software loopback has no such protection. A peer-supplied out-of-bounds offset or oversized write would result in an OOB write past the allocated kernel buffer. Add an explicit bounds check before the memcpy to reject such requests with -EINVAL. Fixes: f7a22071dbf3 ("net/smc: implement DMB-related operations of loopback-ism") Cc: stable@vger.kernel.org Reported-by: Federico Kirschbaum <federico.kirschbaum@xbow.com> Signed-off-by: Dust Li <dust.li@linux.alibaba.com> Reported-by: Baul Lee <baul.lee@xbow.com> Link: https://patch.msgid.link/20260707074318.1448662-1-dust.li@linux.alibaba.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/dibs/dibs_loopback.c')
-rw-r--r--drivers/dibs/dibs_loopback.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/dibs/dibs_loopback.c b/drivers/dibs/dibs_loopback.c
index ec3b48cb0e87..0f2e09311152 100644
--- a/drivers/dibs/dibs_loopback.c
+++ b/drivers/dibs/dibs_loopback.c
@@ -254,6 +254,11 @@ static int dibs_lo_move_data(struct dibs_dev *dibs, u64 dmb_tok,
read_unlock_bh(&ldev->dmb_ht_lock);
return -EINVAL;
}
+ if ((u64)offset + size > rmb_node->len) {
+ read_unlock_bh(&ldev->dmb_ht_lock);
+ return -EINVAL;
+ }
+
memcpy((char *)rmb_node->cpu_addr + offset, data, size);
sba_idx = rmb_node->sba_idx;
read_unlock_bh(&ldev->dmb_ht_lock);