summaryrefslogtreecommitdiff
path: root/drivers/clk/versatile
diff options
context:
space:
mode:
authorGeert Uytterhoeven <geert+renesas@glider.be>2026-08-21 10:53:50 +0200
committerBrian Masney <bmasney@redhat.com>2026-08-31 11:29:39 -0400
commit55798638d98d36f31c6eb2e7b394d1e45452f549 (patch)
tree04eb42ff1a52a7c50c83b2bc3e5a44955b9bee3b /drivers/clk/versatile
parentf3bdb1723be1d72724db69b71df4c6ce8a54bb71 (diff)
downloadlinux-next-55798638d98d36f31c6eb2e7b394d1e45452f549.tar.gz
linux-next-55798638d98d36f31c6eb2e7b394d1e45452f549.zip
clk: versatile: Make sure clk_init_data is fully initialized
The clk_init_data structure contains several mutually-exclusive members for different methods to specify the possible parents of a clock, prompting drivers to initialize only the members they need. However, not initializing all members may cause subtle issues, which are only exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is enabled. Make sure all members are fully initialized, to avoid such bugs, and to prevent future breakage when converting drivers to a different method for specifying the parents. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Linus Walleij <linusw@kernel.org> Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> Message-ID: <7c480e73222bb51982fb82dc0cc6cd503f2e8b92.1787239813.git.geert+renesas@glider.be> Signed-off-by: Brian Masney <bmasney@redhat.com>
Diffstat (limited to 'drivers/clk/versatile')
-rw-r--r--drivers/clk/versatile/clk-icst.c2
-rw-r--r--drivers/clk/versatile/clk-sp810.c2
-rw-r--r--drivers/clk/versatile/clk-vexpress-osc.c2
3 files changed, 3 insertions, 3 deletions
diff --git a/drivers/clk/versatile/clk-icst.c b/drivers/clk/versatile/clk-icst.c
index 6bd3db54dd22..97a1bfd6cf0e 100644
--- a/drivers/clk/versatile/clk-icst.c
+++ b/drivers/clk/versatile/clk-icst.c
@@ -360,8 +360,8 @@ struct clk *icst_clk_setup(struct device *dev,
{
struct clk *clk;
struct clk_icst *icst;
- struct clk_init_data init;
struct icst_params *pclone;
+ struct clk_init_data init = {};
icst = kzalloc_obj(*icst);
if (!icst)
diff --git a/drivers/clk/versatile/clk-sp810.c b/drivers/clk/versatile/clk-sp810.c
index b0e69686f7a9..28e5c0cf1fda 100644
--- a/drivers/clk/versatile/clk-sp810.c
+++ b/drivers/clk/versatile/clk-sp810.c
@@ -86,7 +86,7 @@ static void __init clk_sp810_of_setup(struct device_node *node)
const char *parent_names[2];
int num = ARRAY_SIZE(parent_names);
char name[12];
- struct clk_init_data init;
+ struct clk_init_data init = {};
static int instance;
int i;
bool deprecated;
diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c
index 9adbf5c33bd1..72e872ec6b7c 100644
--- a/drivers/clk/versatile/clk-vexpress-osc.c
+++ b/drivers/clk/versatile/clk-vexpress-osc.c
@@ -64,7 +64,7 @@ static const struct clk_ops vexpress_osc_ops = {
static int vexpress_osc_probe(struct platform_device *pdev)
{
- struct clk_init_data init;
+ struct clk_init_data init = {};
struct vexpress_osc *osc;
u32 range[2];
int ret;