diff options
| author | Eric Biggers <ebiggers@google.com> | 2025-01-29 19:51:21 -0800 |
|---|---|---|
| committer | Eric Biggers <ebiggers@google.com> | 2025-02-08 20:06:22 -0800 |
| commit | 0fcec0b73adc5f86597d342062114b77bcf7ec9d (patch) | |
| tree | e115293f6693c3b2f857b1c0501e4f7bda2f27cc /crypto/Kconfig | |
| parent | feb541bfacbe23bf19a96b96db03e6c7505e1b03 (diff) | |
| download | linux-next-0fcec0b73adc5f86597d342062114b77bcf7ec9d.tar.gz linux-next-0fcec0b73adc5f86597d342062114b77bcf7ec9d.zip | |
crypto: crc64-rocksoft - remove from crypto API
Remove crc64-rocksoft from the crypto API. It has no known user now
that the lib is no longer built on top of it. It was also added much
more recently than the longstanding crc32 and crc32c. Unlike crc32 and
crc32c, crc64-rocksoft is also not mentioned in the dm-integrity
documentation and there are no references to it in anywhere in the
cryptsetup git repo, so it is unlikely to have any user there either.
Also, this CRC variant is named incorrectly; it has nothing to do with
Rocksoft and should be called crc64-nvme. That is yet another reason to
remove it from the crypto API; we would not want anyone to start
depending on the current incorrect algorithm name of crc64-rocksoft.
Note that this change temporarily makes this CRC variant not be covered
by any tests, as previously it was relying on the crypto self-tests.
This will be fixed by adding this CRC variant to crc_kunit.
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: "Martin K. Petersen" <martin.petersen@oracle.com>
Acked-by: Keith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20250130035130.180676-3-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Diffstat (limited to 'crypto/Kconfig')
| -rw-r--r-- | crypto/Kconfig | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/crypto/Kconfig b/crypto/Kconfig index 74ae5f52b784..9ffb59b1aac3 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -1090,17 +1090,6 @@ config CRYPTO_CRCT10DIF CRC algorithm used by the SCSI Block Commands standard. -config CRYPTO_CRC64_ROCKSOFT - tristate "CRC64 based on Rocksoft Model algorithm" - depends on CRC64 - select CRYPTO_HASH - help - CRC64 CRC algorithm based on the Rocksoft Model CRC Algorithm - - Used by the NVMe implementation of T10 DIF (BLK_DEV_INTEGRITY) - - See https://zlib.net/crc_v3.txt - endmenu menu "Compression" |