diff options
| author | Philipp Stanner <phasta@kernel.org> | 2025-12-18 10:28:20 +0100 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2026-01-14 11:00:00 -0600 |
| commit | 94cf23f6b7c3d6551af513b5f3ddba7838312494 (patch) | |
| tree | ed9449bcf8e85565c679e78ba967bf386393ccfa | |
| parent | 80d9411c00e805488b631c91034e9b6c14a6dbdc (diff) | |
| download | linux-next-94cf23f6b7c3d6551af513b5f3ddba7838312494.tar.gz linux-next-94cf23f6b7c3d6551af513b5f3ddba7838312494.zip | |
PCI: Remove useless WARN_ON() from devres
PCI's devres implementation contains a WARN_ON() which served to inform
users relying on the legacy devres iomap table that this table does not
support multiple mappings per BAR.
The WARN_ON() can be regarded as useless by now, since mapping a BAR
multiple times is legal behavior and old users of pcim_iomap_table(), the
accessor function for that table, did not break in the past PCI devres
cleanup. New PCI users will hopefully notice that pcim_iomap_table() is
deprecated and are unlikely to use it for mapping the same BAR multiple
times.
Moreover, WARN_ON()s create noisy, difficult to read error messages which
can be more confusing than helpful, since they don't inform the user about
what precisely the problem is.
Remove the WARN_ON().
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://patch.msgid.link/20251218092819.149665-2-phasta@kernel.org
| -rw-r--r-- | drivers/pci/devres.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/pci/devres.c b/drivers/pci/devres.c index 9f4190501395..f075e7881c3a 100644 --- a/drivers/pci/devres.c +++ b/drivers/pci/devres.c @@ -469,9 +469,6 @@ static int pcim_add_mapping_to_legacy_table(struct pci_dev *pdev, if (!legacy_iomap_table) return -ENOMEM; - /* The legacy mechanism doesn't allow for duplicate mappings. */ - WARN_ON(legacy_iomap_table[bar]); - legacy_iomap_table[bar] = mapping; return 0; |