diff options
| author | Felix Gu <ustc.gu@gmail.com> | 2026-02-12 20:41:40 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-02-13 17:08:24 +0000 |
| commit | 888a0a802c467bbe34a42167bdf9d7331333440a (patch) | |
| tree | c41f97beac1ed5c62e13cc1a2dddc4aa08bc0d37 | |
| parent | 5af56f30c4fcbade4a92f94dadfea517d1db9703 (diff) | |
| download | linux-next-888a0a802c467bbe34a42167bdf9d7331333440a.tar.gz linux-next-888a0a802c467bbe34a42167bdf9d7331333440a.zip | |
spi: wpcm-fiu: Fix potential NULL pointer dereference in wpcm_fiu_probe()
platform_get_resource_byname() can return NULL, which would cause a crash
when passed the pointer to resource_size().
Move the fiu->memory_size assignment after the error check for
devm_ioremap_resource() to prevent the potential NULL pointer dereference.
Fixes: 9838c182471e ("spi: wpcm-fiu: Add direct map support")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: J. Neuschäfer <j.ne@posteo.net>
Link: https://patch.msgid.link/20260212-wpcm-v1-1-5b7c4f526aac@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-wpcm-fiu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-wpcm-fiu.c b/drivers/spi/spi-wpcm-fiu.c index 0e3ee5516587..0e26ff178505 100644 --- a/drivers/spi/spi-wpcm-fiu.c +++ b/drivers/spi/spi-wpcm-fiu.c @@ -459,11 +459,11 @@ static int wpcm_fiu_probe(struct platform_device *pdev) res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "memory"); fiu->memory = devm_ioremap_resource(dev, res); - fiu->memory_size = min_t(size_t, resource_size(res), MAX_MEMORY_SIZE_TOTAL); if (IS_ERR(fiu->memory)) return dev_err_probe(dev, PTR_ERR(fiu->memory), "Failed to map flash memory window\n"); + fiu->memory_size = min_t(size_t, resource_size(res), MAX_MEMORY_SIZE_TOTAL); fiu->shm_regmap = syscon_regmap_lookup_by_phandle_optional(dev->of_node, "nuvoton,shm"); wpcm_fiu_hw_init(fiu); |