summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoy Zou <joy.zou@nxp.com>2026-07-15 17:33:52 +0800
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2026-07-16 12:03:11 -0700
commit7ef54727f5a2deef5c59623f0685056b2e8a1676 (patch)
tree8d24807c3cc7db93ba05076dbb54e26e80f63822
parenta1445ec0be7411f4c76458873ef7456b02688f63 (diff)
downloadlinux-next-7ef54727f5a2deef5c59623f0685056b2e8a1676.tar.gz
linux-next-7ef54727f5a2deef5c59623f0685056b2e8a1676.zip
Input: snvs_pwrkey - propagate error code of platform_get_irq()
Hardcoding -EINVAL discards the actual error code, which breaks probe deferral (-EPROBE_DEFER) and loses critical diagnostic information needed for proper kernel error handling. Reviewed-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Joy Zou <joy.zou@nxp.com> Link: https://patch.msgid.link/20260715-b4-pwrkey-v5-2-07e7353c319e@oss.nxp.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
-rw-r--r--drivers/input/keyboard/snvs_pwrkey.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/snvs_pwrkey.c
index 8cc6863d26ed..d58bbbe9fd58 100644
--- a/drivers/input/keyboard/snvs_pwrkey.c
+++ b/drivers/input/keyboard/snvs_pwrkey.c
@@ -148,7 +148,7 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev)
pdata->irq = platform_get_irq(pdev, 0);
if (pdata->irq < 0)
- return -EINVAL;
+ return pdata->irq;
error = of_property_read_u32(np, "power-off-time-sec", &val);
if (!error) {