diff options
| author | Felix Gu <ustc.gu@gmail.com> | 2026-03-22 21:29:56 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-03-23 18:32:05 +0000 |
| commit | 63542bb402b7013171c9f621c28b609eda4dbf1f (patch) | |
| tree | 935d72fb503ce2175d95ba83f74e423cf73684e4 | |
| parent | a42c9b8b0c00ecd9b7467844f2fbfc766898bf54 (diff) | |
| download | linux-next-63542bb402b7013171c9f621c28b609eda4dbf1f.tar.gz linux-next-63542bb402b7013171c9f621c28b609eda4dbf1f.zip | |
spi: meson-spicc: Fix double-put in remove path
meson_spicc_probe() registers the controller with
devm_spi_register_controller(), so teardown already drops the
controller reference via devm cleanup.
Calling spi_controller_put() again in meson_spicc_remove()
causes a double-put.
Fixes: 8311ee2164c5 ("spi: meson-spicc: fix memory leak in meson_spicc_remove")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260322-rockchip-v1-1-fac3f0c6dad8@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-meson-spicc.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c index a7001b9e36e6..57768da3205d 100644 --- a/drivers/spi/spi-meson-spicc.c +++ b/drivers/spi/spi-meson-spicc.c @@ -1101,8 +1101,6 @@ static void meson_spicc_remove(struct platform_device *pdev) /* Disable SPI */ writel(0, spicc->base + SPICC_CONREG); - - spi_controller_put(spicc->host); } static const struct meson_spicc_data meson_spicc_gx_data = { |