diff options
| author | Tao Cui <cuitao@kylinos.cn> | 2026-09-22 12:38:56 +0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2026-10-16 08:21:06 -0600 |
| commit | 40607f9a6a5eaa071797481bd0ba5ea3ef1eb405 (patch) | |
| tree | 3a30f20b41237a46e6f741e6efca2ba8c23f5833 | |
| parent | c38975c427cc3d3f6eb66a36143893be5cdf4ebd (diff) | |
| download | linux-next-40607f9a6a5eaa071797481bd0ba5ea3ef1eb405.tar.gz linux-next-40607f9a6a5eaa071797481bd0ba5ea3ef1eb405.zip | |
blk-iocost: fix stale comment in ioc_rqos_throttle()
The comment says that priority-inversion IOs are "punted to
@ioc->aux_iocg", but no aux_iocg field ever existed in struct ioc.
The comment was introduced already stale by commit da437b95db83
("blk-iocost: grab ioc->lock for debt handling"). Update it to
describe the current use_debt / iocg->abs_vdebt mechanism.
Signed-off-by: Tao Cui <cuitao@kylinos.cn>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://patch.msgid.link/20260922043856.2020116-5-cui.tao@linux.dev
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | block/blk-iocost.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/block/blk-iocost.c b/block/blk-iocost.c index 9ca58cfbce86..a81488c755ca 100644 --- a/block/blk-iocost.c +++ b/block/blk-iocost.c @@ -2743,10 +2743,11 @@ static void ioc_rqos_throttle(struct rq_qos *rqos, struct bio *bio) /* * We're over budget. This can be handled in two ways. IOs which may - * cause priority inversions are punted to @ioc->aux_iocg and charged as - * debt. Otherwise, the issuer is blocked on @iocg->waitq. Debt handling - * requires @ioc->lock, waitq handling @iocg->waitq.lock. Determine - * whether debt handling is needed and acquire locks accordingly. + * cause priority inversions are issued regardless and charged against + * @iocg->abs_vdebt as debt. Otherwise, the issuer is blocked on + * @iocg->waitq. Debt handling requires @ioc->lock, waitq handling + * @iocg->waitq.lock. Determine whether debt handling is needed and + * acquire locks accordingly. */ use_debt = bio_issue_as_root_blkg(bio) || fatal_signal_pending(current); ioc_locked = use_debt || READ_ONCE(iocg->abs_vdebt); |