diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-09-11 10:43:03 +0300 |
|---|---|---|
| committer | Felix Fietkau <nbd@nbd.name> | 2025-01-13 11:21:54 +0100 |
| commit | 08fa656c91fd5fdf47ba393795b9c0d1e97539ed (patch) | |
| tree | 8ff5eef12cadf9ad1eb15989fda5a78a0bec0a04 | |
| parent | fbce6136da0a40f62ea22361e7d13f6a502c20ad (diff) | |
| download | linux-next-08fa656c91fd5fdf47ba393795b9c0d1e97539ed.tar.gz linux-next-08fa656c91fd5fdf47ba393795b9c0d1e97539ed.zip | |
wifi: mt76: mt7925: fix off by one in mt7925_load_clc()
This comparison should be >= instead of > to prevent an out of bounds
read and write.
Fixes: 9679ca7326e5 ("wifi: mt76: mt7925: fix a potential array-index-out-of-bounds issue for clc")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/84bf5dd2-2fe3-4410-a7af-ae841e41082a@stanley.mountain
Signed-off-by: Felix Fietkau <nbd@nbd.name>
| -rw-r--r-- | drivers/net/wireless/mediatek/mt76/mt7925/mcu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c index 748ea6adbc6b..0c2a2337c313 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c @@ -638,7 +638,7 @@ static int mt7925_load_clc(struct mt792x_dev *dev, const char *fw_name) for (offset = 0; offset < len; offset += le32_to_cpu(clc->len)) { clc = (const struct mt7925_clc *)(clc_base + offset); - if (clc->idx > ARRAY_SIZE(phy->clc)) + if (clc->idx >= ARRAY_SIZE(phy->clc)) break; /* do not init buf again if chip reset triggered */ |