diff options
| author | Gavin Mak <gavinmak@google.com> | 2026-10-26 20:07:24 +0000 |
|---|---|---|
| committer | gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com <gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2026-10-26 14:51:52 -0700 |
| commit | 8c316d7c980d7785578ed98e871dba3d7093b481 (patch) | |
| tree | 8a0377e70d393cb86fa1d28e633c159a8ab7457a /tests/test_subcmds_cherry_pick.py | |
| parent | e3e8e8a3b0509db51ef42c46412af2c59b17db95 (diff) | |
| download | git-repo-main.tar.gz git-repo-main.zip | |
`Project.UploadForReview()` unconditionally passed `--progress` to
`git push`, forcing client and remote progress meters (`Counting
objects`, `remote: Resolving deltas: 3%..100%`) even on non-TTY
stderr or when `-q`/`--quiet` was passed. Meanwhile, `repo upload`
ignored `opt.quiet` completely.
Move `--progress` injection for `push` into `GitCommand` alongside
`fetch` and `clone`, enabling it only when `sys.stderr.isatty()` and
none of `--progress`, `--no-progress`, `--quiet`, or `-q` are set.
Forward `opt.quiet` from `repo upload` to `Project.UploadForReview()`
and pass `--no-progress` to `git push` rather than `--quiet` so
Gerrit `remote: https://...` review URLs are still emitted and parsed
by `_FindGerritUrls()`. Also suppress the non-error `[OK]` summary
banner when `-q`/`--quiet` is set.
Bug: 578114287
Change-Id: I88b7b055dcca0db80dae6962886a693fe717c741
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/649663
Tested-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Brian Gan <brgan@google.com>
Diffstat (limited to 'tests/test_subcmds_cherry_pick.py')
0 files changed, 0 insertions, 0 deletions