diff options
| author | Namhyung Kim <namhyung@kernel.org> | 2024-08-20 23:54:06 -0700 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2024-08-21 11:27:18 -0300 |
| commit | 922ec313f061cf75157d8e93fe16bc6397f6ea25 (patch) | |
| tree | c196c1d3f3a1f09a2edf4122435fdf166d83b42b /tools/perf | |
| parent | e25ebda78e230283bf707ae3e9655270ff40a7f9 (diff) | |
| download | lwn-922ec313f061cf75157d8e93fe16bc6397f6ea25.tar.gz lwn-922ec313f061cf75157d8e93fe16bc6397f6ea25.zip | |
perf annotate-data: Fix missing constant copy
I found it missed to copy the immediate constant when it moves the
register value. This could result in a wrong type inference since the
address for the per-cpu variable would be 0 always.
Fixes: eb9190afaed6afd5 ("perf annotate-data: Handle ADD instructions")
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20240821065408.285548-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf')
| -rw-r--r-- | tools/perf/arch/x86/annotate/instructions.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/perf/arch/x86/annotate/instructions.c b/tools/perf/arch/x86/annotate/instructions.c index 7b7d462c6c6b..88b5bcf2116f 100644 --- a/tools/perf/arch/x86/annotate/instructions.c +++ b/tools/perf/arch/x86/annotate/instructions.c @@ -382,6 +382,7 @@ static void update_insn_state_x86(struct type_state *state, tsr->type = state->regs[src->reg1].type; tsr->kind = state->regs[src->reg1].kind; + tsr->imm_value = state->regs[src->reg1].imm_value; tsr->ok = true; pr_debug_dtp("mov [%x] reg%d -> reg%d", |